Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2973103003: [Android] Remove unnecessary null check in WebappDirectoryManager#findStaleWebappDirectories() (Closed)

Created:
3 years, 5 months ago by pkotwicz
Modified:
3 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove unnecessary null check in WebappDirectoryManager#findStaleWebappDirectories() The check is no longer necessary after https://codereview.chromium.org/1354323003 BUG=713655 Review-Url: https://codereview.chromium.org/2973103003 Cr-Commit-Position: refs/heads/master@{#485103} Committed: https://chromium.googlesource.com/chromium/src/+/36758560e485bfee7d7c5d6b10300e77038fb415

Patch Set 1 : Merge branch 'webapp_directory_manager' into webapp_directory_manager1_5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java View 1 chunk +16 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
pkotwicz
Yaron, can you please take a look?
3 years, 5 months ago (2017-07-07 03:41:29 UTC) #4
Yaron
lgtm
3 years, 5 months ago (2017-07-07 14:16:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973103003/20001
3 years, 5 months ago (2017-07-07 22:52:09 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 23:44:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36758560e485bfee7d7c5d6b1030...

Powered by Google App Engine
This is Rietveld 408576698