Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2973103002: Revert of Update AuraInit to handle failed initialization (Closed)

Created:
3 years, 5 months ago by Fady Samuel
Modified:
3 years, 5 months ago
Reviewers:
jonross, sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update AuraInit to handle failed initialization (patchset #2 id:40001 of https://codereview.chromium.org/2967943002/ ) Reason for revert: Causing chrome --mash to fail to start [118236:118236:0706/142624.101546:3509128143561:ERROR:chrome_main_delegate.cc(1187)] Main process exiting because service ash quit unexpectedly. Original issue's description: > It is possible for AuraInit to fail initialization. If the remote ServiceManager closes while a Service is starting up, then the synchronous calls to Directory will fail before error states are received. > > This change follows up a previous change to AuraInit and QuickLauncher which was addressing these crashes in unittests. It refactors AuraInit to have an explicit initialization method. All callsites are updated to check the success of init, and to close cleanly upon failures. > > TBR=sky@chromium.org > TEST=mash_browser_tests > BUG=678687 > > Review-Url: https://codereview.chromium.org/2967943002 > Cr-Commit-Position: refs/heads/master@{#484583} > Committed: https://chromium.googlesource.com/chromium/src/+/14402447b7df16d16126dc49a3a44cf66c318c88 TBR=sadrul@chromium.org,sky@chromium.org,jonross@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678687 Review-Url: https://codereview.chromium.org/2973103002 Cr-Commit-Position: refs/heads/master@{#484711} Committed: https://chromium.googlesource.com/chromium/src/+/e3f9dbb7b50ab80caf29071bef886c2ec8cee28c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -120 lines) Patch
M ash/autoclick/mus/autoclick_application.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ash/mus/window_manager_application.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mash/catalog_viewer/catalog_viewer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mash/example/views_examples/views_examples.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mash/simple_wm/simple_wm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/mus/aura_init.h View 1 chunk +16 lines, -25 lines 0 comments Download
M ui/views/mus/aura_init.cc View 3 chunks +39 lines, -58 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Fady Samuel
Created Revert of Update AuraInit to handle failed initialization
3 years, 5 months ago (2017-07-06 19:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973103002/1
3 years, 5 months ago (2017-07-06 19:33:02 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 19:33:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3f9dbb7b50ab80caf29071bef88...

Powered by Google App Engine
This is Rietveld 408576698