DescriptionRevert of Update AuraInit to handle failed initialization (patchset #2 id:40001 of https://codereview.chromium.org/2967943002/ )
Reason for revert:
Causing chrome --mash to fail to start
[118236:118236:0706/142624.101546:3509128143561:ERROR:chrome_main_delegate.cc(1187)] Main process exiting because service ash quit unexpectedly.
Original issue's description:
> It is possible for AuraInit to fail initialization. If the remote ServiceManager closes while a Service is starting up, then the synchronous calls to Directory will fail before error states are received.
>
> This change follows up a previous change to AuraInit and QuickLauncher which was addressing these crashes in unittests. It refactors AuraInit to have an explicit initialization method. All callsites are updated to check the success of init, and to close cleanly upon failures.
>
> TBR=sky@chromium.org
> TEST=mash_browser_tests
> BUG=678687
>
> Review-Url: https://codereview.chromium.org/2967943002
> Cr-Commit-Position: refs/heads/master@{#484583}
> Committed: https://chromium.googlesource.com/chromium/src/+/14402447b7df16d16126dc49a3a44cf66c318c88
TBR=sadrul@chromium.org,sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678687
Review-Url: https://codereview.chromium.org/2973103002
Cr-Commit-Position: refs/heads/master@{#484711}
Committed: https://chromium.googlesource.com/chromium/src/+/e3f9dbb7b50ab80caf29071bef886c2ec8cee28c
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|