Make sure NavigationHandleImpl::WillStartRequest only executes once

Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658, 739739
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2973063002
Cr-Commit-Position: refs/heads/master@{#484628}
Committed: https://chromium.googlesource.com/chromium/src/+/55398af747a91e1d9fdd92b66f0b311ef084ae53

[clamy, 2017-07-06 15:10:09]

Description was changed from

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658
==========

to

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-07-06 15:10:15]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 15:11:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 16:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:22:51]

Dry run: This issue passed the CQ dry run.

[clamy, 2017-07-06 16:24:24]

Description was changed from

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658, 739739
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-07-06 16:24:55]

clamy@chromium.org changed reviewers:
+ csharrison@chromium.org

[clamy, 2017-07-06 16:25:09]

@csharrison: PTAL

[Charlie Harrison, 2017-07-06 16:30:36]

LGTM, though I am not sure whether cancelling the navigation is better than just
ignoring the call. I trust your judgement though.

[clamy, 2017-07-06 16:32:24]

On 2017/07/06 16:30:36, Charlie Harrison wrote:
> LGTM, though I am not sure whether cancelling the navigation is better than
just
> ignoring the call. I trust your judgement though.

If we don't find a NavigationHandle for a navigation, we cancel the navigation.
This is because a certain number of security checks are implemented as
NavigationThrottles, and it would be problematic not to execute them. I'm
thinking this case falls under the same umbrella.

[clamy, 2017-07-06 16:32:31]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:32:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 16:38:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499358751745690, "parent_rev":
"cf246f40cec6f44e964d8670e49f3e0096810772", "commit_rev":
"55398af747a91e1d9fdd92b66f0b311ef084ae53"}

[commit-bot: I haz the power, 2017-07-06 16:38:22]

Description was changed from

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658, 739739
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make sure NavigationHandleImpl::WillStartRequest only executes once

This CL ensures that NavigationHandleImpl::WillStartRequest will only
execute once. We've been seeing reports from the field where it seems
it can sometimes execute twice (without PlzNavigate).

BUG=736658, 739739
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2973063002
Cr-Commit-Position: refs/heads/master@{#484628}
Committed:
https://chromium.googlesource.com/chromium/src/+/55398af747a91e1d9fdd92b66f0b...
==========

[commit-bot: I haz the power, 2017-07-06 16:38:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55398af747a91e1d9fdd92b66f0b...