Chromium Code Reviews
DescriptionRevert of Stop updating context menu task items when not changed. (patchset #2 id:20001 of https://codereview.chromium.org/2932803002/ )
Reason for revert:
We'd like to revert 2833413003 because it caused regression crbug.com/738803.
This is change depends on 2833413003.
Original issue's description:
> Stop updating context menu task items when not changed.
>
> During FileSelectionHandler.EventType.CHANGE to CHANGE_THROTTLED,
> existing task items in context menu were overwritten by a temporary
> item. File copy operation fires CHANGE and CHANGE_THROTTLED repeatedly,
> which leads to flickering context menu during copy.
> If selection is not changed, we should not clear the task items in the
> context menu.
>
> BUG=731483
> TEST=manual
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2932803002
> Cr-Commit-Position: refs/heads/master@{#478239}
> Committed: https://chromium.googlesource.com/chromium/src/+/f8c224c31c133a07f58a8d922ec15aa730c06cde
TBR=oka@chromium.org,fukino@chromium.org,tetsui@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=731483, 738803
Review-Url: https://codereview.chromium.org/2973003002
Cr-Commit-Position: refs/heads/master@{#484500}
Committed: https://chromium.googlesource.com/chromium/src/+/aa4c54cbd611f55c475eda159865c7134442f71c
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||