Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2973003002: Revert of Stop updating context menu task items when not changed. (Closed)

Created:
3 years, 5 months ago by yamaguchi
Modified:
3 years, 5 months ago
Reviewers:
oka, tetsui, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stop updating context menu task items when not changed. (patchset #2 id:20001 of https://codereview.chromium.org/2932803002/ ) Reason for revert: We'd like to revert 2833413003 because it caused regression crbug.com/738803. This is change depends on 2833413003. Original issue's description: > Stop updating context menu task items when not changed. > > During FileSelectionHandler.EventType.CHANGE to CHANGE_THROTTLED, > existing task items in context menu were overwritten by a temporary > item. File copy operation fires CHANGE and CHANGE_THROTTLED repeatedly, > which leads to flickering context menu during copy. > If selection is not changed, we should not clear the task items in the > context menu. > > BUG=731483 > TEST=manual > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2932803002 > Cr-Commit-Position: refs/heads/master@{#478239} > Committed: https://chromium.googlesource.com/chromium/src/+/f8c224c31c133a07f58a8d922ec15aa730c06cde TBR=oka@chromium.org,fukino@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=731483, 738803 Review-Url: https://codereview.chromium.org/2973003002 Cr-Commit-Position: refs/heads/master@{#484500} Committed: https://chromium.googlesource.com/chromium/src/+/aa4c54cbd611f55c475eda159865c7134442f71c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M ui/file_manager/file_manager/foreground/js/task_controller.js View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
yamaguchi
Created Revert of Stop updating context menu task items when not changed.
3 years, 5 months ago (2017-07-06 04:44:20 UTC) #1
tetsui
lgtm
3 years, 5 months ago (2017-07-06 07:57:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2973003002/1
3 years, 5 months ago (2017-07-06 08:19:29 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 08:42:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa4c54cbd611f55c475eda159865...

Powered by Google App Engine
This is Rietveld 408576698