MD Bookmarks: Prevent flash of folder contents when changing search term

MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG=737076
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972963003
Cr-Commit-Position: refs/heads/master@{#484494}
Committed: https://chromium.googlesource.com/chromium/src/+/ca6bd61910347a8d6b53299b2a621c312aed7129

[tsergeant, 2017-07-06 04:27:44]

Description was changed from

==========
MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG=737076
==========

to

==========
MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG=737076
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-07-06 04:32:29]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 04:32:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 05:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 05:40:30]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-07-06 05:57:09]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2017-07-06 07:59:30]

lgtm

Side note: a search for spaces is valid and returns no results. Worth dealing
with?

[tsergeant, 2017-07-06 08:09:45]

On 2017/07/06 07:59:30, calamity wrote:
> lgtm
> 
> Side note: a search for spaces is valid and returns no results. Worth dealing
> with?

Hrmm. This also didn't work great in the old BMM, so it's not a regression. I'll
file a P3 bug.

[tsergeant, 2017-07-06 08:09:57]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-07-06 08:10:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 08:21:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499328597375820, "parent_rev":
"bdf4642db91687af930bd9c58dfee693350117fa", "commit_rev":
"64562ae109d91599fe86676b96517a1bb2e41158"}

[commit-bot: I haz the power, 2017-07-06 08:21:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499328597375820, "parent_rev":
"21fd817eaeabd6630057dc9f0135ca55f5cad380", "commit_rev":
"ca6bd61910347a8d6b53299b2a621c312aed7129"}

[commit-bot: I haz the power, 2017-07-06 08:21:31]

Description was changed from

==========
MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG=737076
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Prevent flash of folder contents when changing search term

In MD Bookmarks, changing search term would clear the results of the
current search, then fire off a new search request, which would bring in
new results <1 second later. This caused a brief flash of folder contents
for whatever folder was currently selected.

This CL fixes that issue by holding on to the old search results until
the new search results are available.

BUG=737076
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972963003
Cr-Commit-Position: refs/heads/master@{#484494}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca6bd61910347a8d6b53299b2a62...
==========

[commit-bot: I haz the power, 2017-07-06 08:21:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca6bd61910347a8d6b53299b2a62...