Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2972903002: [Cronet] Disable testMockReadDataAsyncError as it breaks with WeakPtr changes. (Closed)

Created:
3 years, 5 months ago by mef
Modified:
3 years, 5 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Disable testMockReadDataAsyncError as it breaks with WeakPtr changes. BUG=738183 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2972903002 Cr-Commit-Position: refs/heads/master@{#484696} Committed: https://chromium.googlesource.com/chromium/src/+/baaa9eae9337c541976270798c4d0b6609c8bd18

Patch Set 1 #

Patch Set 2 : Disable correct test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
mef
Hi Andrei, PTAL. See the bug for discussion.
3 years, 5 months ago (2017-07-05 22:06:03 UTC) #6
kapishnikov
lgtm
3 years, 5 months ago (2017-07-06 18:45:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972903002/20001
3 years, 5 months ago (2017-07-06 18:47:48 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 18:56:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/baaa9eae9337c541976270798c4d...

Powered by Google App Engine
This is Rietveld 408576698