Split the integration test cases into asan and non asan.

Split the integration test cases into asan and non asan.

BUG=

Review-Url: https://codereview.chromium.org/2972893002
Committed: https://github.com/google/syzygy/commit/5790520bd136e8074ecb0466a51d741f13ad2dc3

[njanevsk, 2017-07-05 21:01:35]

Description was changed from

==========
Split the integration test cases into asan and non asan.

BUG=
==========

to

==========
Split the integration test cases into asan and non asan.

BUG=
==========

[njanevsk, 2017-07-05 21:01:35]

njanevsk@google.com changed reviewers:
+ chrisha@chromium.org, sebmarchand@chromium.org

[njanevsk, 2017-07-05 21:03:36]

This CL contains only the splitting of the test cases. For the python
compilation script to compile the code successfully.

PTAL.

[Sébastien Marchand, 2017-07-06 15:17:57]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 15:18:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2017-07-06 15:33:43]

A few nits, looks good otherwise.

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
File syzygy/integration_tests/integration_tests_dll.h (right):

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
syzygy/integration_tests/integration_tests_dll.h:24: // This macro declares the
SygyAsan tests ids and the function that they're
SyzyAsan, with a Z.

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
syzygy/integration_tests/integration_tests_dll.h:179: 
Remove the extra BLs.

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
syzygy/integration_tests/integration_tests_dll.h:196: // For clang-cl run only
the asan tests.
"Only run the Asan tests for the Clang builds"?

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
syzygy/integration_tests/integration_tests_dll.h:200: #define
END_TO_END_TEST_ID_TABLE(decl) END_TO_END_NON_ASAN_TESTS(decl)
END_TO_END_ASAN_TESTS(decl)
This is > 80 chars.

https://codereview.chromium.org/2972893002/diff/1/syzygy/integration_tests/in...
syzygy/integration_tests/integration_tests_dll.h:209: };
Re-add this BL.

[commit-bot: I haz the power, 2017-07-06 16:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:10:05]

Dry run: This issue passed the CQ dry run.

[njanevsk, 2017-07-06 16:47:57]

The CQ bit was checked by njanevsk@google.com

[commit-bot: I haz the power, 2017-07-06 16:48:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 16:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:48:07]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-syzygy-committers".
Note that this has nothing to do with OWNERS files.

[Sébastien Marchand, 2017-07-06 17:10:20]

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
File syzygy/integration_tests/integration_tests_dll.h (right):

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:180: 
There's still one extra BL :)

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:195: // Only run the Asan tests
for the Clang
You forgot the end of this sentence.

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:199: #define
END_TO_END_TEST_ID_TABLE(decl) \
there should be 2 spaces before the \, run "git cl format" to fix this.

[njanevsk, 2017-07-06 17:19:29]

The CQ bit was checked by njanevsk@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 17:19:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 17:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 17:19:37]

Dry run: No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-syzygy-committers".
Note that this has nothing to do with OWNERS files.

[njanevsk, 2017-07-06 18:15:49]

The CQ bit was checked by njanevsk@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 18:15:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 18:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 18:50:25]

Dry run: Try jobs failed on following builders:
  win_x64_dbg_try on master.tryserver.client.syzygy (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.syzygy/builders/win_x64_dbg_try...)

[njanevsk, 2017-07-06 19:01:20]

Fixed the indentation and did a dry run. During the dry run one test case is
failing. However this test cases is not related to the changes I made. I don't
know why that is happening. The test cases that is failing is:
BlockTest.GetHeaderFromBody

What do you suggest?

PTAL

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
File syzygy/integration_tests/integration_tests_dll.h (right):

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:180: 
On 2017/07/06 17:10:20, Sébastien Marchand wrote:
> There's still one extra BL :)

Done.

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:195: // Only run the Asan tests
for the Clang
On 2017/07/06 17:10:20, Sébastien Marchand wrote:
> You forgot the end of this sentence.

Done.

https://codereview.chromium.org/2972893002/diff/20001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:199: #define
END_TO_END_TEST_ID_TABLE(decl) \
On 2017/07/06 17:10:20, Sébastien Marchand wrote:
> there should be 2 spaces before the \, run "git cl format" to fix this.

Done.

[Sébastien Marchand, 2017-07-06 19:05:41]

lgtm with one last nit. The failing test is a flakiness that I really want to
fix but it doesn't repro on my machine :(, I'll try harder, don't worry about it
in the meantime, just retry the CQ.

https://codereview.chromium.org/2972893002/diff/40001/syzygy/integration_test...
File syzygy/integration_tests/integration_tests_dll.h (right):

https://codereview.chromium.org/2972893002/diff/40001/syzygy/integration_test...
syzygy/integration_tests/integration_tests_dll.h:194: // Only run the Asan tests
for the Clang builds
Missing period :)

[njanevsk, 2017-07-06 19:10:36]

The CQ bit was checked by njanevsk@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 19:10:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 20:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 20:03:36]

Dry run: This issue passed the CQ dry run.

[njanevsk, 2017-07-06 20:20:48]

The CQ bit was checked by njanevsk@google.com

[njanevsk, 2017-07-06 20:20:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
sebmarchand@chromium.org
Link to the patchset: https://codereview.chromium.org/2972893002/#ps60001
(title: "Split the integration test cases into asan and non asan.")

[commit-bot: I haz the power, 2017-07-06 20:20:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 20:21:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499372448365420,
"parent_rev": "e94470d3ee05aff00d26e174307821288263a3ee", "commit_rev":
"5790520bd136e8074ecb0466a51d741f13ad2dc3"}

[commit-bot: I haz the power, 2017-07-06 20:21:11]

Description was changed from

==========
Split the integration test cases into asan and non asan.

BUG=
==========

to

==========
Split the integration test cases into asan and non asan.

BUG=

Review-Url: https://codereview.chromium.org/2972893002
Committed:
https://github.com/google/syzygy/commit/5790520bd136e8074ecb0466a51d741f13ad2dc3
==========

[commit-bot: I haz the power, 2017-07-06 20:21:12]

Committed patchset #4 (id:60001) as
https://github.com/google/syzygy/commit/5790520bd136e8074ecb0466a51d741f13ad2dc3