Issue 2972883002: [vm] Enable mirrors in product mode. Allows building a product mode SDK.

Issue 2972883002: [vm] Enable mirrors in product mode. Allows building a product mode SDK. (Closed)

Created:
3 years, 5 months ago by rmacnak

Modified:
3 years, 5 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -47 lines)			Patch
M	runtime/lib/mirrors.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bootstrap_natives.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flag_list.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	7 chunks	+9 lines, -10 lines	0 comments	Download
M	runtime/vm/object_store.h	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

zra

What is the increase in binary size for both dart and dart_precompiled_runtime?

3 years, 5 months ago (2017-07-07 05:23:12 UTC) #3

rmacnak

On 2017/07/07 05:23:12, zra wrote: > What is the increase in binary size for both ...

3 years, 5 months ago (2017-07-10 20:05:37 UTC) #4

rmacnak

3 years, 5 months ago (2017-07-12 19:56:05 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f20b32b7936ed0ce071f8991a7030705c8aacf19 (presubmit successful).