Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: tests/language/language.status

Issue 2972883002: [vm] Enable mirrors in product mode. Allows building a product mode SDK. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/isolate.status ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/language.status
diff --git a/tests/language/language.status b/tests/language/language.status
index f803bf6a079477c0ebab0969fdadf5e35cb352a7..ea4c866dea38b7b845592cabb014a16d13652e66 100644
--- a/tests/language/language.status
+++ b/tests/language/language.status
@@ -170,7 +170,7 @@ export_ambiguous_main_negative_test: Skip # Issue 29895
[ $compiler == precompiler && $runtime == dart_precompiled && $mode == debug ]
regress_29025_test: Crash # Issue dartbug.com/29331
-[ $runtime == dart_precompiled || $mode == product ]
+[ $runtime == dart_precompiled ]
# Imports dart:mirrors
const_evaluation_test: SkipByDesign
deferred_constraints_constants_test: SkipByDesign
@@ -193,6 +193,8 @@ super_call4_test: SkipByDesign
super_getter_setter_test: SkipByDesign
vm/reflect_core_vm_test: SkipByDesign
regress_28255_test: SkipByDesign
+
+[ $runtime == dart_precompiled || $mode == product ]
# Causal async stacks are not supported in product mode
vm/causal_async_exception_stack_test: SkipByDesign
vm/causal_async_exception_stack2_test: SkipByDesign
@@ -251,11 +253,11 @@ library_env_test/has_no_html_support: RuntimeError, OK
library_env_test/has_html_support: RuntimeError, OK
library_env_test/has_no_io_support: RuntimeError, OK
-[ ($compiler == none || $compiler == app_jit) && $mode != product ]
+[ $compiler == none || $compiler == app_jit ]
# The following tests are supposed to fail.
library_env_test/has_no_mirror_support: RuntimeError, OK
-[ $runtime == dart_precompiled || $mode == product ]
+[ $runtime == dart_precompiled ]
# The following tests are supposed to fail.
library_env_test/has_mirror_support: RuntimeError, OK
« no previous file with comments | « tests/isolate/isolate.status ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698