Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2972863003: Introduce CreateVisibleSelectionWithGranularity() (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce CreateVisibleSelectionWithGranularity() This patch Introduces |CreateVisibleSelectionWithGranularity()| to reduce usages of |SelectionTemplate::SetGranularity()| for a preparation of getting rid of |VisibleSelectio::granularity_|[1]. [1] http://crrev.com/959153002: Get rid of SelectionTemplate::granularity_ BUG=692923 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2972863003 Cr-Commit-Position: refs/heads/master@{#484518} Committed: https://chromium.googlesource.com/chromium/src/+/9ad2300eb815732fda127eb344a43a4eff0a073e

Patch Set 1 : 2017-07-06T16:26:15 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -36 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 3 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +25 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelectionTest.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/WebSubstringUtil.mm View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-07-06 08:46:00 UTC) #6
yoichio
lgtm
3 years, 5 months ago (2017-07-06 09:38:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972863003/1
3 years, 5 months ago (2017-07-06 09:48:26 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 09:52:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ad2300eb815732fda127eb344a4...

Powered by Google App Engine
This is Rietveld 408576698