MD Bookmarks: Always select targeted item during doubleclick

MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=731004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972773003
Cr-Commit-Position: refs/heads/master@{#484516}
Committed: https://chromium.googlesource.com/chromium/src/+/3079afcd6e8193a508ae572c23960a8f304f429b

[tsergeant, 2017-07-06 07:14:51]

Description was changed from

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=
==========

to

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-07-06 07:19:28]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 07:19:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-07-06 07:19:49]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-07-06 07:19:49]

👀

[tsergeant, 2017-07-06 07:20:48]

Description was changed from

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=731004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-07-06 08:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 08:06:35]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[calamity, 2017-07-06 08:08:58]

lgtm

https://codereview.chromium.org/2972773003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/item.js (right):

https://codereview.chromium.org/2972773003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/item.js:152: this.selectThisItem_();
nit: newline

[tsergeant, 2017-07-06 08:23:22]

https://codereview.chromium.org/2972773003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/item.js (right):

https://codereview.chromium.org/2972773003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/item.js:152: this.selectThisItem_();
On 2017/07/06 08:08:58, calamity wrote:
> nit: newline

Done.

[tsergeant, 2017-07-06 08:23:32]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-07-06 08:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2972773003/#ps20001
(title: "Fix nit")

[commit-bot: I haz the power, 2017-07-06 08:23:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 09:34:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499329412876290,
"parent_rev": "15bfa36564d0728a5546d84fdb89cdbe3aa49e76", "commit_rev":
"3079afcd6e8193a508ae572c23960a8f304f429b"}

[commit-bot: I haz the power, 2017-07-06 09:35:01]

Description was changed from

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=731004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Always select targeted item during doubleclick

This CL fixes an issue where a double click while a menu was showing
would open the selection rather than what was clicked. This now selects
and opens the doubleclicked item instead.

BUG=731004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972773003
Cr-Commit-Position: refs/heads/master@{#484516}
Committed:
https://chromium.googlesource.com/chromium/src/+/3079afcd6e8193a508ae572c2396...
==========

[commit-bot: I haz the power, 2017-07-06 09:35:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3079afcd6e8193a508ae572c2396...