Introduce ComputeSelectionMode in LayoutSelection

Introduce ComputeSelectionMode in LayoutSelection

We don't need return valid EphemeralRange if we have visible caret.

BUG=739062
Review-Url: https://codereview.chromium.org/2972773002
Cr-Commit-Position: refs/heads/master@{#484242}
Committed: https://chromium.googlesource.com/chromium/src/+/b12a50aed06cf44cc5ecadc229adcc82d1794717

[yoichio, 2017-07-05 07:29:04]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:29:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 07:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 07:59:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoichio, 2017-07-05 07:59:45]

Description was changed from

==========
Introduce ComputeSelectionMode in LayoutSelection

We don't need valid EphemeralRange if we don't need paint Selection.

BUG=739062
==========

to

==========
Introduce ComputeSelectionMode in LayoutSelection

We don't need return valid EphemeralRange if we have visible caret.

BUG=739062
==========

[yoichio, 2017-07-05 09:01:05]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-07-05 09:32:16]

lgtm

https://codereview.chromium.org/2972773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right):

https://codereview.chromium.org/2972773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/LayoutSelection.cpp:117: static
SelectionMode ComputeSelectionMode(
nit: Could you add a blank line to separate |enum| declaration and function
definition?

[yoichio, 2017-07-05 10:30:13]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-07-05 10:30:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 11:12:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499250613612730, "parent_rev":
"88192782118553e9341132cece3a241c241a3b90", "commit_rev":
"b12a50aed06cf44cc5ecadc229adcc82d1794717"}

[commit-bot: I haz the power, 2017-07-05 11:13:09]

Description was changed from

==========
Introduce ComputeSelectionMode in LayoutSelection

We don't need return valid EphemeralRange if we have visible caret.

BUG=739062
==========

to

==========
Introduce ComputeSelectionMode in LayoutSelection

We don't need return valid EphemeralRange if we have visible caret.

BUG=739062

Review-Url: https://codereview.chromium.org/2972773002
Cr-Commit-Position: refs/heads/master@{#484242}
Committed:
https://chromium.googlesource.com/chromium/src/+/b12a50aed06cf44cc5ecadc229ad...
==========

[commit-bot: I haz the power, 2017-07-05 11:13:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b12a50aed06cf44cc5ecadc229ad...