Use entities internally in MemberTypeInformation

Use entities internally in MemberTypeInformation

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e560a92ae7ffb60fdd12c209f9944180ae518110

[Johnni Winther, 2017-07-04 13:46:23]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-07-04 13:46:24]

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:129: if
(!compiler.resolution.hasBeenResolved(element)) return null;
This would trigger a 'type has not been compute' failure on unresolved field,
trying to create the default FieldTypeInformation object.

[Siggi Cherem (dart-lang), 2017-07-05 21:04:14]

lgtm

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:129: if
(!compiler.resolution.hasBeenResolved(element)) return null;
On 2017/07/04 13:46:24, Johnni Winther wrote:
> This would trigger a 'type has not been compute' failure on unresolved field,
> trying to create the default FieldTypeInformation object.

do you mean we are hitting this issue on programs with input errors?

[Johnni Winther, 2017-07-06 09:38:14]

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/2972653002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:129: if
(!compiler.resolution.hasBeenResolved(element)) return null;
On 2017/07/05 21:04:14, Siggi Cherem (dart-lang) wrote:
> On 2017/07/04 13:46:24, Johnni Winther wrote:
> > This would trigger a 'type has not been compute' failure on unresolved
field,
> > trying to create the default FieldTypeInformation object.
> 
> do you mean we are hitting this issue on programs with input errors?

No. The visiting just eagerly runs through all fields, regardless of whether
they are live or not.

[Johnni Winther, 2017-07-06 09:43:49]

Description was changed from

==========
Use entities internally in MemberTypeInformation
==========

to

==========
Use entities internally in MemberTypeInformation

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e560a92ae7ffb60fdd12c209f9944180ae518110
==========

[Johnni Winther, 2017-07-06 09:43:51]

Committed patchset #1 (id:1) manually as
e560a92ae7ffb60fdd12c209f9944180ae518110 (presubmit successful).