Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: pkg/compiler/lib/src/dump_info.dart

Issue 2972653002: Use entities internally in MemberTypeInformation (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dump_info.dart
diff --git a/pkg/compiler/lib/src/dump_info.dart b/pkg/compiler/lib/src/dump_info.dart
index aee7db62c422361fb3c69b7f05c33b9a5d52f1fc..5a092f3dd50467e361b761d615959009e803519d 100644
--- a/pkg/compiler/lib/src/dump_info.dart
+++ b/pkg/compiler/lib/src/dump_info.dart
@@ -126,6 +126,7 @@ class ElementInfoCollector extends BaseElementVisitor<Info, dynamic> {
compiler.globalInference.results.resultOfParameter(e);
FieldInfo visitFieldElement(FieldElement element, _) {
+ if (!compiler.resolution.hasBeenResolved(element)) return null;
Johnni Winther 2017/07/04 13:46:24 This would trigger a 'type has not been compute' f
Siggi Cherem (dart-lang) 2017/07/05 21:04:14 do you mean we are hitting this issue on programs
Johnni Winther 2017/07/06 09:38:14 No. The visiting just eagerly runs through all fie
TypeMask inferredType = _resultOfMember(element).type;
// If a field has an empty inferred type it is never used.
if (inferredType == null || inferredType.isEmpty) return null;
« no previous file with comments | « no previous file | pkg/compiler/lib/src/inferrer/inferrer_engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698