[Payment Request] Records the use of data models used in Payment Request.

[Payment Request] Records the use of data models used in Payment Request.

BUG=602666
Review-Url: https://codereview.chromium.org/2972643003
Cr-Commit-Position: refs/heads/master@{#484286}
Committed: https://chromium.googlesource.com/chromium/src/+/98ad214b4408ec7ed616861d8f7a0be55ba955e5

[Moe, 2017-07-04 15:30:27]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 15:30:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-07-04 15:36:26]

Patchset #1 (id:1) has been deleted

[Moe, 2017-07-04 15:36:50]

mahmadi@chromium.org changed reviewers:
+ rouslan@chromium.org

[Moe, 2017-07-04 15:36:50]

Hi Rouslan, Please take a look.

[please use gerrit instead, 2017-07-05 12:51:08]

lgtm % comments

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_unittest.mm (right):

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:27: namespace {
Newline after.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:34:
MATCHER_P(DataModelMatches, guid, "") {
s/Data/Guid/

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:37: }  // namespace
Newline before.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:688: }
Please add a test case for different profiles being used for shipping and
contact.

[Moe, 2017-07-05 14:43:19]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-07-05 14:43:20]

Thank you.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_unittest.mm (right):

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:27: namespace {
On 2017/07/05 at 12:51:07, rouslan wrote:
> Newline after.

Done.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:34:
MATCHER_P(DataModelMatches, guid, "") {
On 2017/07/05 at 12:51:07, rouslan wrote:
> s/Data/Guid/

Done.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:37: }  // namespace
On 2017/07/05 at 12:51:07, rouslan wrote:
> Newline before.

Done.

https://codereview.chromium.org/2972643003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_unittest.mm:688: }
On 2017/07/05 at 12:51:07, rouslan wrote:
> Please add a test case for different profiles being used for shipping and
contact.

Done.

[Moe, 2017-07-05 14:43:21]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2972643003/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-07-05 14:43:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 15:59:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499265799657070,
"parent_rev": "f45f1f992e10c183e1a49ab2a011629443e8b565", "commit_rev":
"98ad214b4408ec7ed616861d8f7a0be55ba955e5"}

[commit-bot: I haz the power, 2017-07-05 16:00:05]

Description was changed from

==========
[Payment Request] Records the use of data models used in Payment Request.

BUG=602666
==========

to

==========
[Payment Request] Records the use of data models used in Payment Request.

BUG=602666

Review-Url: https://codereview.chromium.org/2972643003
Cr-Commit-Position: refs/heads/master@{#484286}
Committed:
https://chromium.googlesource.com/chromium/src/+/98ad214b4408ec7ed616861d8f7a...
==========

[commit-bot: I haz the power, 2017-07-05 16:00:07]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/98ad214b4408ec7ed616861d8f7a...