[MD Bookmarks] Add UI for multi-item drag and drop chip.

[MD Bookmarks] Add UI for multi-item drag and drop chip.

This CL makes a secondary div appear behind the drag and drop chip and
a count that shows the number of items being dragged when more than 1
item is dragged.

BUG=729860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972633002
Cr-Commit-Position: refs/heads/master@{#484479}
Committed: https://chromium.googlesource.com/chromium/src/+/571711199808b424ff2d60d9295ef6d802e31c87

[calamity, 2017-07-04 08:38:11]

Description was changed from

==========
[MD Bookmarks] Add UI for multi-item drag and drop chip.

This CL makes a secondary div appear behind the drag and drop chip and
a count that shows the number of items being dragged when more than 1
item is dragged.

BUG=729860
==========

to

==========
[MD Bookmarks] Add UI for multi-item drag and drop chip.

This CL makes a secondary div appear behind the drag and drop chip and
a count that shows the number of items being dragged when more than 1
item is dragged.

BUG=729860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-07-04 08:41:48]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2017-07-05 01:30:25]

Generally looks good. I think it still looks a -little- awkward, but I don't
have any good ideas to improve it.

I'm also a little concerned about the performance, since we spend way more time
'Rendering' than other similar DND UIs (Drive and Files app). I'm trying to dig
into that a bit more now.

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_chip.html (right):

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_chip.html:32: box-shadow: 0 0 8px 0
rgba(0,0,0,0.12), 0 8px 8px 0 rgba(0,0,0,0.24);
Nit: Missed this last time, but these rgba values probably should have spaces in
them.

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_chip.html:88: right: -170px;
This looks a bit wonky in RTL.

[calamity, 2017-07-05 06:59:04]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 06:59:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-07-05 07:10:09]

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_chip.html (right):

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_chip.html:32: box-shadow: 0 0 8px 0
rgba(0,0,0,0.12), 0 8px 8px 0 rgba(0,0,0,0.24);
On 2017/07/05 01:30:25, tsergeant wrote:
> Nit: Missed this last time, but these rgba values probably should have spaces
in
> them.

Done. Surprised the linter didn't catch this.

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_chip.html:88: right: -170px;
On 2017/07/05 01:30:25, tsergeant wrote:
> This looks a bit wonky in RTL.

Fixed. But frankly, I don't know how to parse RTL so... RTL looks a bit wonky to
_me_ >_>

[tsergeant, 2017-07-05 07:36:19]

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_chip.html (right):

https://codereview.chromium.org/2972633002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_chip.html:32: box-shadow: 0 0 8px 0
rgba(0,0,0,0.12), 0 8px 8px 0 rgba(0,0,0,0.24);
On 2017/07/05 07:10:09, calamity wrote:
> On 2017/07/05 01:30:25, tsergeant wrote:
> > Nit: Missed this last time, but these rgba values probably should have
spaces
> in
> > them.
> 
> Done. Surprised the linter didn't catch this.

The CSS linter only checks a few specific things rather than the whole style
guide

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/dnd_chip.html (right):

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/dnd_chip.html:13: --chip-height: 40px;
Nit: sort these

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/dnd_chip.html:94: left: 0;
Nit: Should this be 2px to match the LTR equivalent of starting 2px from the
edge?

[commit-bot: I haz the power, 2017-07-05 08:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 08:17:48]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[calamity, 2017-07-06 05:05:15]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[calamity, 2017-07-06 05:05:20]

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/dnd_chip.html (right):

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/dnd_chip.html:13: --chip-height: 40px;
On 2017/07/05 07:36:19, tsergeant wrote:
> Nit: sort these

Done.

https://codereview.chromium.org/2972633002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/dnd_chip.html:94: left: 0;
On 2017/07/05 07:36:19, tsergeant wrote:
> Nit: Should this be 2px to match the LTR equivalent of starting 2px from the
> edge?

Done.

[commit-bot: I haz the power, 2017-07-06 05:05:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-07-06 06:02:00]

lgtm

[commit-bot: I haz the power, 2017-07-06 06:07:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 06:07:29]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-07-06 06:27:13]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2017-07-06 06:27:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 06:33:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499322433738970,
"parent_rev": "e65a6eccff55c9b055307c45421ff74756a09f36", "commit_rev":
"571711199808b424ff2d60d9295ef6d802e31c87"}

[commit-bot: I haz the power, 2017-07-06 06:33:27]

Description was changed from

==========
[MD Bookmarks] Add UI for multi-item drag and drop chip.

This CL makes a secondary div appear behind the drag and drop chip and
a count that shows the number of items being dragged when more than 1
item is dragged.

BUG=729860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Add UI for multi-item drag and drop chip.

This CL makes a secondary div appear behind the drag and drop chip and
a count that shows the number of items being dragged when more than 1
item is dragged.

BUG=729860
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2972633002
Cr-Commit-Position: refs/heads/master@{#484479}
Committed:
https://chromium.googlesource.com/chromium/src/+/571711199808b424ff2d60d9295e...
==========

[commit-bot: I haz the power, 2017-07-06 06:33:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/571711199808b424ff2d60d9295e...