Support C and Objective-C in jumbo base scripts.

Support C and Objective-C in jumbo base scripts.

Up until now only C++ files were merged. With this Objective-C
will also be merged and if there are any C files (there are only
a few spread out) then those will also be handled.

BUG=713137
Review-Url: https://codereview.chromium.org/2972533002
Cr-Commit-Position: refs/heads/master@{#484230}
Committed: https://chromium.googlesource.com/chromium/src/+/2733ee3f00fbb5201eb94c294bfc913c998401f0

[Daniel Bratell, 2017-07-03 13:56:57]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 13:57:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 14:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 14:17:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Daniel Bratell, 2017-07-03 15:15:36]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 15:15:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 15:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 15:20:19]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Bratell, 2017-07-03 15:22:13]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 15:22:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 17:34:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 17:34:26]

Dry run: This issue passed the CQ dry run.

[Daniel Bratell, 2017-07-04 11:37:43]

bratell@opera.com changed reviewers:
+ brucedawson@chromium.org, dpranke@chromium.org

[Daniel Bratell, 2017-07-04 11:37:44]

Happy national day to you!

Here is Objective-C support for jumbo as well.

https://codereview.chromium.org/2972533002/diff/60001/build/config/jumbo.gni
File build/config/jumbo.gni (right):

https://codereview.chromium.org/2972533002/diff/60001/build/config/jumbo.gni#...
build/config/jumbo.gni:10: use_jumbo_build = !is_official_build && !(is_android
&& !is_clang)
Just to make cq test it. Must not be committed.

[Dirk Pranke, 2017-07-04 17:15:16]

lgtm w/ the todo addressed.

https://codereview.chromium.org/2972533002/diff/60001/build/config/jumbo.gni
File build/config/jumbo.gni (right):

https://codereview.chromium.org/2972533002/diff/60001/build/config/jumbo.gni#...
build/config/jumbo.gni:104: }
Clever. I hadn't thought of an obvious way to do this in GN.

https://codereview.chromium.org/2972533002/diff/60001/build/config/merge_for_...
File build/config/merge_for_jumbo.py (right):

https://codereview.chromium.org/2972533002/diff/60001/build/config/merge_for_...
build/config/merge_for_jumbo.py:23: # TODO: Check if the file is right already
and then do not update it.
You might as well do this before landing the change, it's not hard and it's the
right thing to do.

https://codereview.chromium.org/2972533002/diff/60001/build/config/merge_for_...
build/config/merge_for_jumbo.py:61: inputs = [x for x in all_inputs if
x.endswith(ext_pattern)]
interesting, I didn't realize you could pass a tuple to endswith().

[Daniel Bratell, 2017-07-04 19:33:49]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 19:33:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 20:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 20:05:46]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Daniel Bratell, 2017-07-05 07:26:41]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:26:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-05 07:28:02]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:28:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-05 07:30:28]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:30:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 07:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 07:41:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniel Bratell, 2017-07-05 07:55:08]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:55:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-05 07:55:50]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 07:55:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Bratell, 2017-07-05 09:21:46]

https://codereview.chromium.org/2972533002/diff/60001/build/config/merge_for_...
File build/config/merge_for_jumbo.py (right):

https://codereview.chromium.org/2972533002/diff/60001/build/config/merge_for_...
build/config/merge_for_jumbo.py:23: # TODO: Check if the file is right already
and then do not update it.
On 2017/07/04 17:15:16, Dirk Pranke wrote:
> You might as well do this before landing the change, it's not hard and it's
the
> right thing to do.

Done.

[Daniel Bratell, 2017-07-05 09:22:50]

The CQ bit was unchecked by bratell@opera.com

[Daniel Bratell, 2017-07-05 09:22:51]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-07-05 09:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2972533002/#ps180001
(title: "Drop testing code again")

[Daniel Bratell, 2017-07-05 09:22:52]

The CQ bit was unchecked by bratell@opera.com

[Daniel Bratell, 2017-07-05 09:22:56]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-07-05 09:23:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 09:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1499246576171120,
"parent_rev": "9674f91392448498aec24b9cc210c608c6476c2c", "commit_rev":
"2733ee3f00fbb5201eb94c294bfc913c998401f0"}

[commit-bot: I haz the power, 2017-07-05 09:49:04]

Description was changed from

==========
Support C and Objective-C in jumbo base scripts.

Up until now only C++ files were merged. With this Objective-C
will also be merged and if there are any C files (there are only
a few spread out) then those will also be handled.

BUG=713137
==========

to

==========
Support C and Objective-C in jumbo base scripts.

Up until now only C++ files were merged. With this Objective-C
will also be merged and if there are any C files (there are only
a few spread out) then those will also be handled.

BUG=713137

Review-Url: https://codereview.chromium.org/2972533002
Cr-Commit-Position: refs/heads/master@{#484230}
Committed:
https://chromium.googlesource.com/chromium/src/+/2733ee3f00fbb5201eb94c294bfc...
==========

[commit-bot: I haz the power, 2017-07-05 09:49:07]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/2733ee3f00fbb5201eb94c294bfc...