[wasm] Improve precision of slow DCHECK for WebAssembly-constructed internal objects.

[wasm] Improve precision of slow DCHECK for WebAssembly-constructed internal objects.

BUG=chromium:740325
R=ahaas@chromium.org,mlippautz@chromium.org

Review-Url: https://codereview.chromium.org/2972353002
Cr-Commit-Position: refs/heads/master@{#46518}
Committed: https://chromium.googlesource.com/v8/v8/+/11484e7e9b83564a0e0f08f02dae9e81c9fc5910

[titzer, 2017-07-10 12:37:14]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 12:37:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 12:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 12:39:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/25440)

[ahaas, 2017-07-10 12:42:49]

lgtm

lgtm with a question.

https://codereview.chromium.org/2972353002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2972353002/diff/1/src/objects.cc#newcode15879
src/objects.cc:15879: // function template info, since that would make the V8 GC
identify them to
What do you mean by the "would" here? Does it make the V8 GC identify them to
the embedder or not?

[Michael Lippautz, 2017-07-10 12:49:11]

LGTM.

[titzer, 2017-07-10 13:16:46]

https://codereview.chromium.org/2972353002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2972353002/diff/1/src/objects.cc#newcode15879
src/objects.cc:15879: // function template info, since that would make the V8 GC
identify them to
On 2017/07/10 12:42:48, ahaas wrote:
> What do you mean by the "would" here? Does it make the V8 GC identify them to
> the embedder or not?

Without this change, the V8 GC (correctly) does not identify them to the
embedder. This change only affects the DCHECKS above, which were imprecise,
since WASM objects also use FunctionTemplateInfo.

[titzer, 2017-07-10 13:17:40]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 13:17:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 13:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-10 13:44:19]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-07-10 13:46:24]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-07-10 13:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2972353002/#ps20001
(title: "Fix compile error and add testcase.")

[commit-bot: I haz the power, 2017-07-10 13:46:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 13:49:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499694384509120,
"parent_rev": "bb881c88803e68ba515e4089654d578580fbb168", "commit_rev":
"11484e7e9b83564a0e0f08f02dae9e81c9fc5910"}

[commit-bot: I haz the power, 2017-07-10 13:49:43]

Description was changed from

==========
[wasm] Improve precision of slow DCHECK for WebAssembly-constructed internal
objects.

BUG=chromium:740325
R=ahaas@chromium.org,mlippautz@chromium.org
==========

to

==========
[wasm] Improve precision of slow DCHECK for WebAssembly-constructed internal
objects.

BUG=chromium:740325
R=ahaas@chromium.org,mlippautz@chromium.org

Review-Url: https://codereview.chromium.org/2972353002
Cr-Commit-Position: refs/heads/master@{#46518}
Committed:
https://chromium.googlesource.com/v8/v8/+/11484e7e9b83564a0e0f08f02dae9e81c9f...
==========

[commit-bot: I haz the power, 2017-07-10 13:49:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/11484e7e9b83564a0e0f08f02dae9e81c9f...