Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2972333002: autofill : Use ContainsValue() instead of std::find() in components/autofill (Closed)

Created:
3 years, 5 months ago by deejay
Modified:
3 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

autofill : Use ContainsValue() instead of std::find() in components/autofill This simplifies many conditions around the code. BUG=561800 Review-Url: https://codereview.chromium.org/2972333002 Cr-Commit-Position: refs/heads/master@{#485186} Committed: https://chromium.googlesource.com/chromium/src/+/b9961fe396a889a0cc806dd4ebc18ecc9267bc7b

Patch Set 1 #

Total comments: 4

Patch Set 2 : add base/stl_util.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/address.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
deejay
Dear @vabr, and reviewers, Hi, I'm deejay. This is clean-up patch that simplifies many conditions ...
3 years, 5 months ago (2017-07-09 17:13:54 UTC) #3
vabr (Chromium)
Hi deejay, Thanks for the clean-up. Please address the comments below, after that this patch ...
3 years, 5 months ago (2017-07-09 18:24:00 UTC) #4
deejay
Dear Vaclav, Thanks for reviewing. Oh! I see. I will add just one OWNER when ...
3 years, 5 months ago (2017-07-10 03:47:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972333002/20001
3 years, 5 months ago (2017-07-10 03:48:20 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 05:02:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9961fe396a889a0cc806dd4ebc1...

Powered by Google App Engine
This is Rietveld 408576698