autofill : Use ContainsValue() instead of std::find() in components/autofill

autofill : Use ContainsValue() instead of std::find() in components/autofill

This simplifies many conditions around the code.

BUG=561800
Review-Url: https://codereview.chromium.org/2972333002
Cr-Commit-Position: refs/heads/master@{#485186}
Committed: https://chromium.googlesource.com/chromium/src/+/b9961fe396a889a0cc806dd4ebc18ecc9267bc7b

[deejay, 2017-07-09 17:08:48]

Description was changed from

==========
autofill : Use ContainsValue() instead of std::find() in components/autofill

This simplifies many conditions around the code.

BUG=561800
==========

to

==========
autofill : Use ContainsValue() instead of std::find() in components/autofill

This simplifies many conditions around the code.

BUG=561800
==========

[deejay, 2017-07-09 17:08:48]

djmix.kim@samsung.com changed reviewers:
+ estade@chromium.org, mathp@chromium.org, rogerm@chromium.org,
sebsg@chromium.org, vabr@chromium.org

[deejay, 2017-07-09 17:13:54]

Dear @vabr, and reviewers,

Hi, I'm deejay. This is clean-up patch that simplifies many conditions around
the code. Could you review this patch-set?

[vabr (Chromium), 2017-07-09 18:24:00]

Hi deejay,

Thanks for the clean-up. Please address the comments below, after that this
patch LGTM.

Cheers,
Vaclav

P.S. You should only add one OWNER, not all of them. Adding all make them all
read the e-mail and potentially duplicate effort reviewing the patch.

https://codereview.chromium.org/2972333002/diff/1/components/autofill/content...
File components/autofill/content/renderer/password_generation_agent.cc (right):

https://codereview.chromium.org/2972333002/diff/1/components/autofill/content...
components/autofill/content/renderer/password_generation_agent.cc:61: return
base::ContainsValue(urls, url);
Please also #include "base/stl_util.h" in this file.

https://codereview.chromium.org/2972333002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/2972333002/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager.cc:1118: return
base::ContainsValue(country_codes, base::ToLowerASCII(country_code));
Please also #include "base/stl_util.h" in this file.

[deejay, 2017-07-10 03:47:17]

Dear Vaclav,
Thanks for reviewing.
Oh! I see. I will add just one OWNER when I update patch later.

https://codereview.chromium.org/2972333002/diff/1/components/autofill/content...
File components/autofill/content/renderer/password_generation_agent.cc (right):

https://codereview.chromium.org/2972333002/diff/1/components/autofill/content...
components/autofill/content/renderer/password_generation_agent.cc:61: return
base::ContainsValue(urls, url);
On 2017/07/09 18:23:59, vabr (Chromium) wrote:
> Please also #include "base/stl_util.h" in this file.

Done.

https://codereview.chromium.org/2972333002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/2972333002/diff/1/components/autofill/core/br...
components/autofill/core/browser/personal_data_manager.cc:1118: return
base::ContainsValue(country_codes, base::ToLowerASCII(country_code));
On 2017/07/09 18:23:59, vabr (Chromium) wrote:
> Please also #include "base/stl_util.h" in this file.

Done.

[deejay, 2017-07-10 03:48:10]

The CQ bit was checked by djmix.kim@samsung.com

[deejay, 2017-07-10 03:48:11]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2972333002/#ps20001
(title: "add base/stl_util.h")

[commit-bot: I haz the power, 2017-07-10 03:48:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 05:02:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499658490660840,
"parent_rev": "b5e64b1f780dcaa7ac6070a06a39218f7f07e72a", "commit_rev":
"b9961fe396a889a0cc806dd4ebc18ecc9267bc7b"}

[commit-bot: I haz the power, 2017-07-10 05:02:16]

Description was changed from

==========
autofill : Use ContainsValue() instead of std::find() in components/autofill

This simplifies many conditions around the code.

BUG=561800
==========

to

==========
autofill : Use ContainsValue() instead of std::find() in components/autofill

This simplifies many conditions around the code.

BUG=561800

Review-Url: https://codereview.chromium.org/2972333002
Cr-Commit-Position: refs/heads/master@{#485186}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9961fe396a889a0cc806dd4ebc1...
==========

[commit-bot: I haz the power, 2017-07-10 05:02:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9961fe396a889a0cc806dd4ebc1...