Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2972273002: DevTools: Page.setDocumentContent without using DOMPatchSupport (Closed)

Created:
3 years, 5 months ago by luoe
Modified:
3 years, 5 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Page.setDocumentContent without using DOMPatchSupport BUG=739462 Review-Url: https://codereview.chromium.org/2972273002 Cr-Commit-Position: refs/heads/master@{#485113} Committed: https://chromium.googlesource.com/chromium/src/+/7299ed5a97695accbb5b04e269ac05ec9366d30b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
A third_party/WebKit/LayoutTests/inspector-protocol/page/setDocumentContent.js View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector-protocol/page/setDocumentContent-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
luoe
I considered Document::write() as well, but it does more which I think we don't need, ...
3 years, 5 months ago (2017-07-07 19:34:00 UTC) #2
caseq
lgtm
3 years, 5 months ago (2017-07-07 22:22:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972273002/1
3 years, 5 months ago (2017-07-08 00:25:06 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 00:29:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7299ed5a97695accbb5b04e269ac...

Powered by Google App Engine
This is Rietveld 408576698