Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 297223006: Always fully qualify the namespace to use in v8.h (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Always fully qualify the namespace to use in v8.h Also, remove some unused methods. BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M include/v8.h View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 09:24:33 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-05-26 09:34:52 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 09:36:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698