Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: include/v8.h

Issue 297223006: Always fully qualify the namespace to use in v8.h (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index bfd3de043821b2ec0033c7d004260b39ca16ca5a..656aa355691a322fb16b1157f2a66b3c1ae04aba 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -5648,13 +5648,14 @@ class Internals {
return reinterpret_cast<internal::Object**>(addr + index * kApiPointerSize);
}
- template <typename T> V8_INLINE static T ReadField(Object* ptr, int offset) {
+ template <typename T>
+ V8_INLINE static T ReadField(internal::Object* ptr, int offset) {
uint8_t* addr = reinterpret_cast<uint8_t*>(ptr) + offset - kHeapObjectTag;
return *reinterpret_cast<T*>(addr);
}
template <typename T>
- V8_INLINE static T ReadEmbedderData(Context* context, int index) {
+ V8_INLINE static T ReadEmbedderData(v8::Context* context, int index) {
typedef internal::Object O;
typedef internal::Internals I;
O* ctx = *reinterpret_cast<O**>(context);
@@ -5665,14 +5666,6 @@ class Internals {
I::kFixedArrayHeaderSize + (internal::kApiPointerSize * index);
return I::ReadField<T>(embedder_data, value_offset);
}
-
- V8_INLINE static bool CanCastToHeapObject(void* o) { return false; }
- V8_INLINE static bool CanCastToHeapObject(Context* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(String* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(Object* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(Message* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(StackTrace* o) { return true; }
- V8_INLINE static bool CanCastToHeapObject(StackFrame* o) { return true; }
};
} // namespace internal
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698