Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2972223002: Revert https://codereview.chromium.org/2860033003 (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Revert https://codereview.chromium.org/2860033003 This refactored how the ProxyConfigTrackerImpl starts up, and broke proxy configuration on ChromeOS in the process. The issue has been at least partially fixed on trunk, but issue does not appear to be completely fixed. This also reverts https://codereview.chromium.org/2872903006, a small CL that has no impact on behavior, which was landed on top of the other CL. Revert "Don't delay creation of system URLRequestContext until first use." This reverts commit 02505dac8a35d644e38d27b01e48645ce39599bc. Revert "Use URLRequestContextStorage for the SystemURLRequestContext." This reverts commit f2e53b2bec633349e045fd4566d841289a295247. TBR=mmenke@chromium.org BUG=734565 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2972223002 Cr-Commit-Position: refs/branch-heads/3112@{#562} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/28255e31f57b4aa645e1a3d9acc02a133537d347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -149 lines) Patch
M chrome/browser/io_thread.h View 9 chunks +31 lines, -9 lines 0 comments Download
M chrome/browser/io_thread.cc View 12 chunks +114 lines, -82 lines 0 comments Download
M chrome/test/base/testing_io_thread_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/proxy_config/pref_proxy_config_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc View 7 chunks +9 lines, -42 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972223002/1
3 years, 5 months ago (2017-07-10 18:19:45 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-10 18:19:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972223002/1
3 years, 5 months ago (2017-07-10 18:21:46 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 5 months ago (2017-07-10 18:21:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972223002/1
3 years, 5 months ago (2017-07-10 18:37:54 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 18:38:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28255e31f57b4aa645e1a3d9acc0...

Powered by Google App Engine
This is Rietveld 408576698