Use unique variable names in gperf generated code

Use unique variable names in gperf generated code

By default gperf generates code with the types and variables
stringpool_t and stringpool. If jumbo combines more than one gperf
generated file those collides.

This patch changes the variable names to something more unique.

R=fs@opera.com
BUG=713137
Review-Url: https://codereview.chromium.org/2972193002
Cr-Commit-Position: refs/heads/master@{#484961}
Committed: https://chromium.googlesource.com/chromium/src/+/d0fbcabbd9fe9c624a67fdc14379697c83cb6798

[Daniel Bratell, 2017-07-07 12:53:44]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 12:53:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-07-07 12:58:30]

lgtm

https://codereview.chromium.org/2972193002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_css_value_keywords.py (right):

https://codereview.chromium.org/2972193002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_css_value_keywords.py:177:
gperf_args.extend(['-Q', 'ValueStringPool'])  # Unique var names.
Maybe CSSValueStringPool?

[Daniel Bratell, 2017-07-07 13:20:50]

https://codereview.chromium.org/2972193002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_css_value_keywords.py (right):

https://codereview.chromium.org/2972193002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_css_value_keywords.py:177:
gperf_args.extend(['-Q', 'ValueStringPool'])  # Unique var names.
On 2017/07/07 12:58:30, fs wrote:
> Maybe CSSValueStringPool?

Done.

[Daniel Bratell, 2017-07-07 13:20:57]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-07-07 13:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2972193002/#ps20001
(title: "fixup better gperf variable name")

[commit-bot: I haz the power, 2017-07-07 13:21:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 17:04:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499433657344060,
"parent_rev": "df6e5a5c7e7c665603f9619930a1d7106b55160d", "commit_rev":
"d0fbcabbd9fe9c624a67fdc14379697c83cb6798"}

[commit-bot: I haz the power, 2017-07-07 17:05:04]

Description was changed from

==========
Use unique variable names in gperf generated code

By default gperf generates code with the types and variables
stringpool_t and stringpool. If jumbo combines more than one gperf
generated file those collides.

This patch changes the variable names to something more unique.

R=fs@opera.com
BUG=713137
==========

to

==========
Use unique variable names in gperf generated code

By default gperf generates code with the types and variables
stringpool_t and stringpool. If jumbo combines more than one gperf
generated file those collides.

This patch changes the variable names to something more unique.

R=fs@opera.com
BUG=713137

Review-Url: https://codereview.chromium.org/2972193002
Cr-Commit-Position: refs/heads/master@{#484961}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0fbcabbd9fe9c624a67fdc14379...
==========

[commit-bot: I haz the power, 2017-07-07 17:05:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d0fbcabbd9fe9c624a67fdc14379...