Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2972153002:
Refactor FrameSelection::RevealSelection (Closed)
|
Created:
3 years, 5 months ago by yoichio Modified:
3 years, 5 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor FrameSelection::RevealSelection
Early return and delay rect computation until need.
BUG=739062
Review-Url: https://codereview.chromium.org/2972153002
Cr-Commit-Position: refs/heads/master@{#484870}
Committed: https://chromium.googlesource.com/chromium/src/+/af5eed337751ca4f227f80a722c3c374dcf7973e
Patch Set 1 #Patch Set 2 : update #
Total comments: 1
Patch Set 3 : update #Patch Set 4 : clang fix #Messages
Total messages: 25 (17 generated)
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Refactor FrameSelection::RevealSelection BUG=739062 ========== to ========== Refactor FrameSelection::RevealSelection Early return and delay rect computation until need. BUG=739062 ==========
yoichio@chromium.org changed reviewers: + yosin@chromium.org
lgtm https://codereview.chromium.org/2972153002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/2972153002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/FrameSelection.cpp:973: LayoutRect rect; Let's move this switch-statement into a function in another patch. Or if you want it is OK to move to function this patch.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2972153002/#ps40001 (title: "update")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoichio@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2972153002/#ps60001 (title: "clang fix")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499415045340800,
"parent_rev": "6ddb8d2861199ccbde41579460d35b0eb625cacf", "commit_rev":
"af5eed337751ca4f227f80a722c3c374dcf7973e"}
Message was sent while issue was closed.
Description was changed from ========== Refactor FrameSelection::RevealSelection Early return and delay rect computation until need. BUG=739062 ========== to ========== Refactor FrameSelection::RevealSelection Early return and delay rect computation until need. BUG=739062 Review-Url: https://codereview.chromium.org/2972153002 Cr-Commit-Position: refs/heads/master@{#484870} Committed: https://chromium.googlesource.com/chromium/src/+/af5eed337751ca4f227f80a722c3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/af5eed337751ca4f227f80a722c3... |
