Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2972133002: Restored vm-connect Observatory_UI tests (Closed)

Created:
3 years, 5 months ago by cbernaschina
Modified:
3 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restored vm-connect Observatory_UI tests Closes #27714 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/992c4aa8add16c9f61f0254b0920cd486d8aedc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M runtime/observatory/lib/src/app/application.dart View 3 chunks +17 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 4 chunks +6 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect_target.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/target.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/repositories/target.dart View 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/target.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
cbernaschina
3 years, 5 months ago (2017-07-07 01:04:03 UTC) #3
rmacnak
lgtm
3 years, 5 months ago (2017-07-07 20:31:57 UTC) #4
cbernaschina
3 years, 5 months ago (2017-07-07 20:34:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
992c4aa8add16c9f61f0254b0920cd486d8aedc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698