Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: runtime/observatory/lib/src/repositories/target.dart

Issue 2972133002: Restored vm-connect Observatory_UI tests (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/repositories/target.dart
diff --git a/runtime/observatory/lib/src/repositories/target.dart b/runtime/observatory/lib/src/repositories/target.dart
index 333e00dc09e38a32313ba560751ac6d5b2e927de..f5a11187d144470a7ad26ae2ceb8bbe2b7ace839 100644
--- a/runtime/observatory/lib/src/repositories/target.dart
+++ b/runtime/observatory/lib/src/repositories/target.dart
@@ -4,6 +4,8 @@
part of repositories;
+typedef bool IsConnectedVMTargetDelegate(Target);
+
class TargetChangeEvent implements M.TargetChangeEvent {
final TargetRepository repository;
final bool disconnected;
@@ -19,14 +21,15 @@ class TargetRepository implements M.TargetRepository {
final List<SC.WebSocketVMTarget> _list = <SC.WebSocketVMTarget>[];
SC.WebSocketVMTarget current;
+ final IsConnectedVMTargetDelegate _isConnectedVMTarget;
- factory TargetRepository() {
+ factory TargetRepository(IsConnectedVMTargetDelegate isConnectedVMTarget) {
var controller = new StreamController<TargetChangeEvent>();
var stream = controller.stream.asBroadcastStream();
- return new TargetRepository._(controller, stream);
+ return new TargetRepository._(isConnectedVMTarget, controller, stream);
}
- TargetRepository._(this._onChange, this.onChange) {
+ TargetRepository._(this._isConnectedVMTarget, this._onChange, this.onChange) {
_restore();
// Add the default address if it doesn't already exist.
if (find(_networkAddressOfDefaultTarget()) == null) {
@@ -108,4 +111,6 @@ class TargetRepository implements M.TargetRepository {
Uri serverAddress = Uri.parse(window.location.toString());
return 'ws://${serverAddress.authority}${serverAddress.path}ws';
}
+
+ bool isConnectedVMTarget(M.Target target) => _isConnectedVMTarget(target);
}

Powered by Google App Engine
This is Rietveld 408576698