chrome/renderer/resources/plugins/pdf_plugin.html - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/plugins/pdf_plugin.html

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: remove id since it's not used Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/plugins/pdf_plugin.html

diff --git a/chrome/renderer/resources/plugins/pdf_plugin.html b/chrome/renderer/resources/plugins/pdf_plugin.html

index 914903256e23004722191ddb0e02493b9dd3798a..52b4c49e863d2c24e3da43d936e0c53d6babde44 100644

--- a/chrome/renderer/resources/plugins/pdf_plugin.html

+++ b/chrome/renderer/resources/plugins/pdf_plugin.html

@@ -2,8 +2,13 @@

<html>

<head>

+ <meta name="viewport" content="width=device-width, user-scalable=no">

</head>

<body>

+ <div i18n-values="title:name">

+ <p id="fileName">$i18n{fileName}</p>

+ <a href="#" onclick="plugin.downloadPDF()">View PDF</a>

Lei Zhang 2017/07/07 17:45:45 Since this uses JS, does that mean if the user has

Lei Zhang 2017/07/07 17:45:45 I'm still curious what happens if the href is siml

amberwon 2017/07/07 20:44:22 It still seems to work, though not entirely sure w

amberwon 2017/07/07 20:44:22 Links don't seem to open within the placeholder.

+ </div>

</body>

</html>