chrome/renderer/resources/plugins/pdf_plugin.html - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/resources/plugins/pdf_plugin.html

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: remove id since it's not used Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

	5 <meta name="viewport" content="width=device-width, user-scalable=no">

5 </head>	6 </head>

6 <body>	7 <body>

7 <!-- TODO(amberwon): Add html with the finalized UI. -->	8 <!-- TODO(amberwon): Add html with the finalized UI. -->

	9 <div i18n-values="title:name">

	10 <p id="fileName">$i18n{fileName}</p>

	11 <a href="#" onclick="plugin.downloadPDF()">View PDF</a>
	Lei Zhang 2017/07/07 17:45:45 Since this uses JS, does that mean if the user has Since this uses JS, does that mean if the user has JS disabled in content setting, then this won't work? Lei Zhang 2017/07/07 17:45:45 I'm still curious what happens if the href is siml I'm still curious what happens if the href is simlply set to the link of the PDF to download. amberwon 2017/07/07 20:44:22 It still seems to work, though not entirely sure w Show quoted text On 2017/07/07 17:45:45, Lei Zhang wrote: > Since this uses JS, does that mean if the user has JS disabled in content > setting, then this won't work? It still seems to work, though not entirely sure why. amberwon 2017/07/07 20:44:22 Links don't seem to open within the placeholder. Show quoted text On 2017/07/07 17:45:45, Lei Zhang wrote: > I'm still curious what happens if the href is simlply set to the link of the PDF > to download. Links don't seem to open within the placeholder.
	12 </div>

8 </body>	13 </body>

9 </html>	14 </html>

OLD	NEW