Click to Open PDF: Open PDF once View PDF is clicked.

chrome/browser/plugins/plugin_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_observer.h"
 
 #include <utility>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 249 matching lines @@
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_BlockedOutdatedPlugin,
                         OnBlockedOutdatedPlugin)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_BlockedComponentUpdatedPlugin,
                         OnBlockedComponentUpdatedPlugin)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RemovePluginPlaceholderHost,
                         OnRemovePluginPlaceholderHost)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ShowFlashPermissionBubble,
                         OnShowFlashPermissionBubble)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CouldNotLoadPlugin,
                         OnCouldNotLoadPlugin)
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_OpenPDF, OnOpenPDF)
 
     IPC_MESSAGE_UNHANDLED(return false)
   IPC_END_MESSAGE_MAP()
 
   return true;
 }
 
 void PluginObserver::OnBlockedOutdatedPlugin(int placeholder_id,
                                              const std::string& identifier) {
   PluginFinder* finder = PluginFinder::GetInstance();
@@ skipping 48 matching lines @@
       plugin_path);
   base::string16 plugin_name =
       PluginService::GetInstance()->GetPluginDisplayNameByPath(plugin_path);
   SimpleAlertInfoBarDelegate::Create(
       InfoBarService::FromWebContents(web_contents()),
       infobars::InfoBarDelegate::PLUGIN_OBSERVER, &kExtensionCrashedIcon,
       l10n_util::GetStringFUTF16(IDS_PLUGIN_INITIALIZATION_ERROR_PROMPT,
                                  plugin_name),
       true);
 }
+
+void PluginObserver::OnOpenPDF(const GURL& url) {
+  web_contents()->OpenURL(content::OpenURLParams(
+      url,
+      content::Referrer::SanitizeForRequest(
+          url, content::Referrer(web_contents()->GetURL(),
+                                 blink::kWebReferrerPolicyDefault)),
+      WindowOpenDisposition::NEW_FOREGROUND_TAB,
+      ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

[Lei Zhang, 2017/07/07 22:47:58]

I'm not sure if these are correct, but I also don't know the right answers. Can
you explain why you chose PAGE_TRANSITION_AUTO_BOOKMARK, and
is_renderer_initiated = false?

[amberwon, 2017/07/11 18:08:05]

They were used for OnOpenAboutPlugins, when the placeholder for PDF's showed a
link to chrome://plugins. So I chose them again here.
PAGE_TRANSITION_AUTO_BOOKMARK means that the user got to this page through a
suggestion in the UI.
is_renderer_initiated indicates whether the navigation is initiated by the
renderer process. In this case, the browser process initiates it.

[Lei Zhang, 2017/07/12 00:51:37]

Well, since the code being referred to was removed in https://crrev.com/443581,
I'll add dcheng@ as the security reviewer for this CL. Some of the code looks
familiar, but there is the addition of a GURL parameter.

+}