Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2972103002: Remove ExecutableElement.labels altogether. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -70 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 4 chunks +0 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_element.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-06 20:24:02 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-06 20:30:32 UTC) #2
scheglov
3 years, 5 months ago (2017-07-06 21:32:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49da688b0b63bfbc57c3023c4bcad89baf9f8b28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698