Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 2972103002: Remove ExecutableElement.labels altogether. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/lib/src/dart/element/handle.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 7d4560dece302380fe8755325c87d264552e06a8..d313a165421782528b6f591bdb244d67d11e705d 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -3561,11 +3561,6 @@ abstract class ExecutableElementImpl extends ElementImpl
List<FunctionElement> _functions;
/**
- * A list containing all of the labels defined within this executable element.
- */
- List<LabelElement> _labels;
-
- /**
* A list containing all of the parameters defined by this executable element.
*/
List<ParameterElement> _parameters;
@@ -3745,27 +3740,6 @@ abstract class ExecutableElementImpl extends ElementImpl
bool get isSynchronous => !isAsynchronous;
@override
- List<LabelElement> get labels {
- if (serializedExecutable != null) {
- _labels ??= LabelElementImpl.resynthesizeList(
- this, serializedExecutable.localLabels);
- }
- return _labels ?? const <LabelElement>[];
- }
-
- /**
- * Set the labels defined within this executable element to the given
- * [labels].
- */
- void set labels(List<LabelElement> labels) {
- _assertNotResynthesized(serializedExecutable);
- for (LabelElement label in labels) {
- (label as LabelElementImpl).enclosingElement = this;
- }
- this._labels = labels;
- }
-
- @override
List<ElementAnnotation> get metadata {
if (serializedExecutable != null) {
return _metadata ??=
@@ -3924,12 +3898,6 @@ abstract class ExecutableElementImpl extends ElementImpl
return functionImpl;
}
}
- for (LabelElement label in _labels) {
- LabelElementImpl labelImpl = label;
- if (labelImpl.identifier == identifier) {
- return labelImpl;
- }
- }
for (ParameterElement parameter in parameters) {
ParameterElementImpl parameterImpl = parameter;
if (parameterImpl.identifier == identifier) {
@@ -3946,7 +3914,6 @@ abstract class ExecutableElementImpl extends ElementImpl
safelyVisitChildren(typeParameters, visitor);
safelyVisitChildren(parameters, visitor);
safelyVisitChildren(functions, visitor);
- safelyVisitChildren(labels, visitor);
}
}
« no previous file with comments | « pkg/analyzer/lib/src/dart/element/builder.dart ('k') | pkg/analyzer/lib/src/dart/element/handle.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698