Enable Clear-Site-Data by default.

Enable Clear-Site-Data by default.

BUG=607897
Review-Url: https://codereview.chromium.org/2972083002
Cr-Commit-Position: refs/heads/master@{#484890}
Committed: https://chromium.googlesource.com/chromium/src/+/7d08794ea091f1a9d5684b0056fbf88fed090298

[msramek, 2017-07-06 18:59:05]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 18:59:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-07-06 20:09:33]

msramek@chromium.org changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org

[msramek, 2017-07-06 20:09:34]

Hi Jochen and Matt!

Jochen: As discussed offline, I'm enabling Clear-Site-Data even though WPTs are
still WIP. Please approve as a Blink API owner.

Matt: PTAL as the code owner.

Thanks!
Martin

[mmenke, 2017-07-06 20:18:22]

On 2017/07/06 20:09:34, msramek (slow) wrote:
> Hi Jochen and Matt!
> 
> Jochen: As discussed offline, I'm enabling Clear-Site-Data even though WPTs
are
> still WIP. Please approve as a Blink API owner.
> 
> Matt: PTAL as the code owner.
> 
> Thanks!
> Martin

Aren't there some tests that force the experimental features flag to be enabled
that no longer need to do so?

[msramek, 2017-07-06 20:30:46]

On 2017/07/06 20:18:22, mmenke wrote:
> On 2017/07/06 20:09:34, msramek (slow) wrote:
> > Hi Jochen and Matt!
> > 
> > Jochen: As discussed offline, I'm enabling Clear-Site-Data even though WPTs
> are
> > still WIP. Please approve as a Blink API owner.
> > 
> > Matt: PTAL as the code owner.
> > 
> > Thanks!
> > Martin
> 
> Aren't there some tests that force the experimental features flag to be
enabled
> that no longer need to do so?

Yes, actually. I had removed that part from the unittest earlier, but forgot
about the browsertest. Done.

[msramek, 2017-07-06 20:31:46]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 20:32:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-06 20:33:00]

On 2017/07/06 20:30:46, msramek (slow) wrote:
> On 2017/07/06 20:18:22, mmenke wrote:
> > On 2017/07/06 20:09:34, msramek (slow) wrote:
> > > Hi Jochen and Matt!
> > > 
> > > Jochen: As discussed offline, I'm enabling Clear-Site-Data even though
WPTs
> > are
> > > still WIP. Please approve as a Blink API owner.
> > > 
> > > Matt: PTAL as the code owner.
> > > 
> > > Thanks!
> > > Martin
> > 
> > Aren't there some tests that force the experimental features flag to be
> enabled
> > that no longer need to do so?
> 
> Yes, actually. I had removed that part from the unittest earlier, but forgot
> about the browsertest. Done.

LGTM!

[commit-bot: I haz the power, 2017-07-06 20:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 20:35:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jochen (gone - plz use gerrit), 2017-07-07 07:47:03]

don't you need to change RuntimeEnabledFeatures.json5?

[msramek, 2017-07-07 09:38:38]

We don't have an entry in that file; the entire implementation is actually in
//src/content, not in Blink, so we just used the flag at the one place you see
in this CL. Do you want me to add that?

[jochen (gone - plz use gerrit), 2017-07-07 09:44:12]

ah, interesting.

lgtm then

[msramek, 2017-07-07 09:53:54]

Thanks both!

Rebased over the patch failure (header addition/removal collision) and landing.

[msramek, 2017-07-07 09:53:59]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-07-07 09:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2972083002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-07-07 09:54:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 11:46:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499421239126780,
"parent_rev": "f251d6591f25c3b769e47aee16f82ffabafb19b0", "commit_rev":
"7d08794ea091f1a9d5684b0056fbf88fed090298"}

[commit-bot: I haz the power, 2017-07-07 11:46:15]

Description was changed from

==========
Enable Clear-Site-Data by default.

BUG=607897
==========

to

==========
Enable Clear-Site-Data by default.

BUG=607897

Review-Url: https://codereview.chromium.org/2972083002
Cr-Commit-Position: refs/heads/master@{#484890}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d08794ea091f1a9d5684b0056fb...
==========

[commit-bot: I haz the power, 2017-07-07 11:46:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7d08794ea091f1a9d5684b0056fb...