Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2972023002: Deduplicate CopyBytes in modules/crypto (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews, shalamov, mlamouri+watch-blink_chromium.org, timvolodine, hongchan, blink-reviews, wanming.lin, haraken, mfoltz+watch_chromium.org, Raymond Toy, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deduplicate CopyBytes in modules/crypto The two identical functions CopyBytes collided in a jumbo build so this is primarily to avoid having to exclude one of the files from the jumbo building. BUG= Review-Url: https://codereview.chromium.org/2972023002 Cr-Commit-Position: refs/heads/master@{#485231} Committed: https://chromium.googlesource.com/chromium/src/+/a54aa6109b10457fc62be6eafb8f15732874c708

Patch Set 1 #

Patch Set 2 : Unnecessary typedef causing conflicts #

Patch Set 3 : fetch triggers crbug.com/739340 #

Patch Set 4 : Dropped the "test in jumbo" code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M third_party/WebKit/Source/modules/crypto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/crypto/CryptoUtilities.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
Daniel Bratell
eroman, PTAL When jumbo compiling modules (not on master yet) I got conflicts because there ...
3 years, 5 months ago (2017-07-07 12:05:27 UTC) #14
eroman
lgtm!
3 years, 5 months ago (2017-07-07 21:32:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2972023002/60001
3 years, 5 months ago (2017-07-10 09:20:22 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 11:22:07 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a54aa6109b10457fc62be6eafb8f...

Powered by Google App Engine
This is Rietveld 408576698