Fix matrix interpolation between rotations of 180 degrees

Fix matrix interpolation between rotations of 180 degrees

In a previous cl (https://chromium-review.googlesource.com/526993), I
intentionally avoided interpolating decomposed rotation components
if they differed by 180 degrees (because this was ambiguous). This does
not match the spec (https://www.w3.org/TR/css-transforms-1/#interpolation-of-decomposed-3d-matrix-values)

This change reverts us to the previous rotation behavior.

BUG=739723
Review-Url: https://codereview.chromium.org/2971903005
Cr-Commit-Position: refs/heads/master@{#484678}
Committed: https://chromium.googlesource.com/chromium/src/+/799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56

[Ian Vollick, 2017-07-06 15:17:07]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[Ian Vollick, 2017-07-06 15:17:21]

vollick@chromium.org changed reviewers:
+ danakj@chromium.org, mthiesse@chromium.org

[commit-bot: I haz the power, 2017-07-06 15:17:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-07-06 15:41:07]

LGTM

https://codereview.chromium.org/2971903005/diff/1/ui/gfx/geometry/quaternion_...
File ui/gfx/geometry/quaternion_unittest.cc (right):

https://codereview.chromium.org/2971903005/diff/1/ui/gfx/geometry/quaternion_...
ui/gfx/geometry/quaternion_unittest.cc:146: // an arbitrary direction.
Do you not want to mention/link to spec stuff?

[Ian Vollick, 2017-07-06 15:45:59]

https://codereview.chromium.org/2971903005/diff/1/ui/gfx/geometry/quaternion_...
File ui/gfx/geometry/quaternion_unittest.cc (right):

https://codereview.chromium.org/2971903005/diff/1/ui/gfx/geometry/quaternion_...
ui/gfx/geometry/quaternion_unittest.cc:146: // an arbitrary direction.
On 2017/07/06 15:41:06, danakj wrote:
> Do you not want to mention/link to spec stuff?

Done.

[Ian Vollick, 2017-07-06 15:46:15]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2017-07-06 15:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2971903005/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-07-06 15:46:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 16:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 16:26:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ian Vollick, 2017-07-06 16:38:04]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 16:38:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 18:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 18:14:15]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2017-07-06 18:17:41]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2017-07-06 18:17:41]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2971903005/#ps40001
(title: "forgot to revert a corresponding unit test")

[commit-bot: I haz the power, 2017-07-06 18:17:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 18:22:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499365061113570,
"parent_rev": "384a07bd840a30d9e778cc642036e079a7aa92ec", "commit_rev":
"799b4a3caeaaa5b99fea35d3ce3a96f7553b8f56"}

[commit-bot: I haz the power, 2017-07-06 18:22:26]

Description was changed from

==========
Fix matrix interpolation between rotations of 180 degrees

In a previous cl (https://chromium-review.googlesource.com/526993), I
intentionally avoided interpolating decomposed rotation components
if they differed by 180 degrees (because this was ambiguous). This does
not match the spec
(https://www.w3.org/TR/css-transforms-1/#interpolation-of-decomposed-3d-matrix...)

This change reverts us to the previous rotation behavior.

BUG=739723
==========

to

==========
Fix matrix interpolation between rotations of 180 degrees

In a previous cl (https://chromium-review.googlesource.com/526993), I
intentionally avoided interpolating decomposed rotation components
if they differed by 180 degrees (because this was ambiguous). This does
not match the spec
(https://www.w3.org/TR/css-transforms-1/#interpolation-of-decomposed-3d-matrix...)

This change reverts us to the previous rotation behavior.

BUG=739723

Review-Url: https://codereview.chromium.org/2971903005
Cr-Commit-Position: refs/heads/master@{#484678}
Committed:
https://chromium.googlesource.com/chromium/src/+/799b4a3caeaaa5b99fea35d3ce3a...
==========

[commit-bot: I haz the power, 2017-07-06 18:22:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/799b4a3caeaaa5b99fea35d3ce3a...