Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2971903003:
mus-gpu: Add support for tracking allocated gpu memory. (Closed)
|
Created:
3 years, 5 months ago by sadrul Modified:
3 years, 5 months ago Reviewers:
reveman CC:
blundell+watchlist_chromium.org, cc-bugs_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionmus-gpu: Add support for tracking allocated gpu memory.
Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can
report the gpu memory usage by various clients.
BUG=733482
Review-Url: https://codereview.chromium.org/2971903003
Cr-Commit-Position: refs/heads/master@{#485151}
Committed: https://chromium.googlesource.com/chromium/src/+/227004835aacc330a48440eae31f4aa1e666dcb8
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : . #
Total comments: 2
Patch Set 5 : . #
Messages
Total messages: 27 (22 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== mus-gpu: Add support for tracking allocated gpu memory. ... BUG=733482 ========== to ========== mus-gpu: Add support for tracking allocated gpu memory. Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can report the gpu memory usage by various clients. BUG=733482 ==========
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sadrul@chromium.org changed reviewers: + reveman@chromium.org
lgtm, just a question https://codereview.chromium.org/2971903003/diff/60001/components/viz/host/ser... File components/viz/host/server_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2971903003/diff/60001/components/viz/host/ser... components/viz/host/server_gpu_memory_buffer_manager.cc:19: using base::trace_event::MemoryDumpManager; what's the justification for this? I think we prefer to not do this in chromium code but maybe there's some style rule that I'm not aware of that makes it a good idea here?
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2971903003/diff/60001/components/viz/host/ser... File components/viz/host/server_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2971903003/diff/60001/components/viz/host/ser... components/viz/host/server_gpu_memory_buffer_manager.cc:19: using base::trace_event::MemoryDumpManager; On 2017/07/08 11:14:10, reveman wrote: > what's the justification for this? I think we prefer to not do this in chromium > code but maybe there's some style rule that I'm not aware of that makes it a > good idea here? I have removed it. Initially I was registering as a dump-provider from within the ctor, but removed it for now, because it will probably need to change when used from chrome, because of how it registers on the UI thread, but unregisters on the IO thread. And the fully qualified name is too long! I think we do not allow using 'using' in headers, but in .cc files is acceptable I believe ("git gs '^using [a-zA-Z:]*;'" shows a fair amount of usage).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2971903003/#ps80001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499553065365270,
"parent_rev": "022f7eda761d42e3eb2126fff1b2e8566f5db98a", "commit_rev":
"227004835aacc330a48440eae31f4aa1e666dcb8"}
Message was sent while issue was closed.
Description was changed from ========== mus-gpu: Add support for tracking allocated gpu memory. Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can report the gpu memory usage by various clients. BUG=733482 ========== to ========== mus-gpu: Add support for tracking allocated gpu memory. Make ServerGpuMemoryBufferManager a MemoryDumpProvider, so that it can report the gpu memory usage by various clients. BUG=733482 Review-Url: https://codereview.chromium.org/2971903003 Cr-Commit-Position: refs/heads/master@{#485151} Committed: https://chromium.googlesource.com/chromium/src/+/227004835aacc330a48440eae31f... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/227004835aacc330a48440eae31f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
