Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3781)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2971823002: Cleanup Tool WebUI: Add logs upload checkbox and minor polishing (Closed)
Patch Set: Address ftirelo's review comments and try fix closure compilation Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index a4c40064daf1ade7296d1a4b97d2ae240dcd605f..cf39e0eb58fe324f70d6c31344ce25b273414e4b 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -788,6 +788,7 @@ void AddChromeCleanupStrings(content::WebUIDataSource* html_source) {
{"chromeCleanupDoneButtonLabel",
IDS_CHROME_CLEANUP_WEBUI_DONE_BUTTON_LABEL},
{"chromeCleanupLinkShowFiles", IDS_CHROME_CLEANUP_WEBUI_LINK_SHOW_FILES},
+ {"chromeCleanupLogsUploadPermission", IDS_CHROME_CLEANUP_LOGS_PERMISSION},
{"chromeCleanupRemoveButtonLabel",
IDS_CHROME_CLEANUP_WEBUI_REMOVE_BUTTON_LABEL},
{"chromeCleanupRestartButtonLabel",
@@ -801,6 +802,12 @@ void AddChromeCleanupStrings(content::WebUIDataSource* html_source) {
};
AddLocalizedStringsBulk(html_source, localized_strings,
arraysize(localized_strings));
+ std::string cleanup_learn_more_url =
ftirelo 2017/07/05 20:24:50 Nitty nit: this can be const.
proberge 2017/07/06 21:12:56 Done.
+ google_util::AppendGoogleLocaleParam(
+ GURL(chrome::kChromeCleanerLearnMoreURL),
+ g_browser_process->GetApplicationLocale())
+ .spec();
+ html_source->AddString("chromeCleanupLearnMoreUrl", cleanup_learn_more_url);
}
#endif // defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698