chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp - Issue 2971823002: Cleanup Tool WebUI: Add logs upload checkbox and minor polishing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp

Issue 2971823002: Cleanup Tool WebUI: Add logs upload checkbox and minor polishing (Closed)

Patch Set: Address ftirelo's review comments and try fix closure compilation Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html ('K') | « chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js ('k') | chrome/browser/ui/webui/settings/chrome_cleanup_handler.h » ('j') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp

diff --git a/chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp b/chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp

index 1d6d6fcad6d673136b17c67dc022c95b9c4653b0..cf0a623927cb8a4024aedc99af22cf43e0e82d7d 100644

--- a/chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp

+++ b/chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp

@@ -20,6 +20,7 @@

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:load_time_data',

'<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:web_ui_listener_behavior',

'chrome_cleanup_proxy',

+ '<(EXTERNS_GYP):settings_private',

tommycli 2017/07/06 19:00:13 should go below <(DEPTH) entries.

proberge 2017/07/06 21:12:56 Done.

'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi'],