Change Toggle High Contrast accelerator

Change Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2971773003
Cr-Commit-Position: refs/heads/master@{#484799}
Committed: https://chromium.googlesource.com/chromium/src/+/470ac8ad6279aeecc13ea5349dbc842ab0eb39f6

[afakhry, 2017-07-05 20:29:16]

Description was changed from

==========
Deprecate Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
==========

to

==========
Deprecate Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-07-05 20:31:12]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 20:31:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-07-05 20:32:11]

afakhry@chromium.org changed reviewers:
+ oshima@chromium.org

[afakhry, 2017-07-05 20:32:11]

Oshima-san, please take a look. Thank you.

[commit-bot: I haz the power, 2017-07-05 22:32:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 22:32:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not
started yet; builder either lacks capacity or does not exist (misspelled?))
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[oshima, 2017-07-06 15:43:52]

lgtm

[afakhry, 2017-07-06 18:15:46]

afakhry@chromium.org changed reviewers:
+ michaelpg@chromium.org, mpearson@google.com

[afakhry, 2017-07-06 18:15:47]

+michaelpg@ for keyboard_overlay_data.js
+mpearson@ for histograms.xml

Thanks.

[Mark P, 2017-07-06 18:23:39]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2017-07-06 18:23:40]

histograms.xml lgtm

[michaelpg, 2017-07-06 20:08:17]

lgtm, but s/Deprecate/Change

[afakhry, 2017-07-06 20:38:08]

Description was changed from

==========
Deprecate Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Change Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-07-06 20:42:04]

On 2017/07/06 20:08:17, michaelpg wrote:
> lgtm, but s/Deprecate/Change

Done.

[afakhry, 2017-07-06 20:42:22]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-07-06 20:42:22]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
mpearson@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2971773003/#ps20001
(title: "Rebase + Change commit message")

[commit-bot: I haz the power, 2017-07-06 20:42:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 21:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 21:22:13]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[afakhry, 2017-07-06 21:38:20]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-07-06 21:38:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 23:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 23:46:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[afakhry, 2017-07-07 00:12:14]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2017-07-07 00:12:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 02:18:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499386334465940,
"parent_rev": "3c5beeea83f51e8847d4d42df996e4cbaf75e224", "commit_rev":
"470ac8ad6279aeecc13ea5349dbc842ab0eb39f6"}

[commit-bot: I haz the power, 2017-07-07 02:18:54]

Description was changed from

==========
Change Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Change Toggle High Contrast accelerator

Due to accidental triggering of High Contrast accelerator, we are
implemnting the following plan:

1: search+shift+h should stop working and display a notification
   that the shortcut has changed.
2: ctrl+search+h should be the new combo
3: Keyboard overlay should update with the change.

BUG=738214
TEST=covered by tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2971773003
Cr-Commit-Position: refs/heads/master@{#484799}
Committed:
https://chromium.googlesource.com/chromium/src/+/470ac8ad6279aeecc13ea5349dbc...
==========

[commit-bot: I haz the power, 2017-07-07 02:18:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/470ac8ad6279aeecc13ea5349dbc...