Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2971753003: Add DownloadPDF Callback function. (Closed)

Created:
3 years, 5 months ago by amberwon
Modified:
3 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DownloadPDF Callback function. Added stub for callback function. Will be called in pdf_plugin.html to start downloading the PDF. Was tested manually by adding a link that calls the function. BUG=737787 Review-Url: https://codereview.chromium.org/2971753003 Cr-Commit-Position: refs/heads/master@{#484369} Committed: https://chromium.googlesource.com/chromium/src/+/bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/renderer/plugins/pdf_plugin_placeholder.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/pdf_plugin_placeholder.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
amberwon
3 years, 5 months ago (2017-07-05 19:37:14 UTC) #2
tommycli
LGTM with below nits Please also expand CL description a bit. https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins/pdf_plugin_placeholder.cc File chrome/renderer/plugins/pdf_plugin_placeholder.cc (right): ...
3 years, 5 months ago (2017-07-05 19:46:24 UTC) #3
amberwon
https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins/pdf_plugin_placeholder.cc File chrome/renderer/plugins/pdf_plugin_placeholder.cc (right): https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins/pdf_plugin_placeholder.cc#newcode43 chrome/renderer/plugins/pdf_plugin_placeholder.cc:43: return builder; On 2017/07/05 19:46:23, tommycli wrote: > I ...
3 years, 5 months ago (2017-07-05 19:54:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971753003/40001
3 years, 5 months ago (2017-07-05 19:54:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-05 21:55:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971753003/40001
3 years, 5 months ago (2017-07-05 23:31:07 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 23:35:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bff2c9eb427afcdc4f2162ec8b64...

Powered by Google App Engine
This is Rietveld 408576698