Add DownloadPDF Callback function.

Add DownloadPDF Callback function.

Added stub for callback function. Will be called in pdf_plugin.html to
start downloading the PDF. Was tested manually by adding a link that
calls the function.

BUG=737787
Review-Url: https://codereview.chromium.org/2971753003
Cr-Commit-Position: refs/heads/master@{#484369}
Committed: https://chromium.googlesource.com/chromium/src/+/bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079

[amberwon, 2017-07-05 19:37:14]

amberwon@google.com changed reviewers:
+ tommycli@chromium.org

[tommycli, 2017-07-05 19:46:24]

LGTM with below nits

Please also expand CL description a bit.

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
File chrome/renderer/plugins/pdf_plugin_placeholder.cc (right):

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
chrome/renderer/plugins/pdf_plugin_placeholder.cc:43: return builder;
I think you can just return it directly like here:
https://cs.chromium.org/chromium/src/components/plugins/renderer/plugin_place...

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
chrome/renderer/plugins/pdf_plugin_placeholder.cc:47: // TODO(amberwon):
Download PDF.
TODO(amberwon): Implement starting PDF download.

[amberwon, 2017-07-05 19:53:38]

Description was changed from

==========
Add DownloadPDF Callback function.

BUG=737787
==========

to

==========
Add DownloadPDF Callback function.

Added stub for callback function. Will be called in pdf_plugin.html to
start downloading the PDF. Was tested manually by adding a link that
calls the function.

BUG=737787
==========

[amberwon, 2017-07-05 19:54:03]

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
File chrome/renderer/plugins/pdf_plugin_placeholder.cc (right):

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
chrome/renderer/plugins/pdf_plugin_placeholder.cc:43: return builder;
On 2017/07/05 19:46:23, tommycli wrote:
> I think you can just return it directly like here:
>
https://cs.chromium.org/chromium/src/components/plugins/renderer/plugin_place...

Done.

https://codereview.chromium.org/2971753003/diff/20001/chrome/renderer/plugins...
chrome/renderer/plugins/pdf_plugin_placeholder.cc:47: // TODO(amberwon):
Download PDF.
On 2017/07/05 19:46:23, tommycli wrote:
> TODO(amberwon): Implement starting PDF download.

Done.

[amberwon, 2017-07-05 19:54:14]

The CQ bit was checked by amberwon@google.com

[amberwon, 2017-07-05 19:54:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2971753003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-07-05 19:54:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 21:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 21:55:36]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not
started yet; builder either lacks capacity or does not exist (misspelled?))
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[amberwon, 2017-07-05 23:30:46]

The CQ bit was checked by amberwon@google.com

[commit-bot: I haz the power, 2017-07-05 23:31:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 23:35:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499297446982050,
"parent_rev": "ad5b9e54353ce83b4805f4d3e9ba5cc5fec90102", "commit_rev":
"bff2c9eb427afcdc4f2162ec8b64e95c4aa3f079"}

[commit-bot: I haz the power, 2017-07-05 23:35:23]

Description was changed from

==========
Add DownloadPDF Callback function.

Added stub for callback function. Will be called in pdf_plugin.html to
start downloading the PDF. Was tested manually by adding a link that
calls the function.

BUG=737787
==========

to

==========
Add DownloadPDF Callback function.

Added stub for callback function. Will be called in pdf_plugin.html to
start downloading the PDF. Was tested manually by adding a link that
calls the function.

BUG=737787

Review-Url: https://codereview.chromium.org/2971753003
Cr-Commit-Position: refs/heads/master@{#484369}
Committed:
https://chromium.googlesource.com/chromium/src/+/bff2c9eb427afcdc4f2162ec8b64...
==========

[commit-bot: I haz the power, 2017-07-05 23:35:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bff2c9eb427afcdc4f2162ec8b64...