Change CookieStore::DeleteCallback to take uint32_t.

Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG=721395
R=mmenke@chromium.org
TBR=sgurun@chromium.org
TBR=mkwst@chromium.org
TBR=sky@chromium.org
TBR=jam@chromium.org 
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2971733002
Cr-Commit-Position: refs/heads/master@{#485148}
Committed: https://chromium.googlesource.com/chromium/src/+/a5beda16555c10b32becc695dd03481ea61b9b98

[Randy Smith (Not in Mondays), 2017-07-04 14:08:10]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 14:08:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 14:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 14:27:43]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Randy Smith (Not in Mondays), 2017-07-04 14:55:40]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 14:55:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Randy Smith (Not in Mondays), 2017-07-04 14:58:51]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-04 14:59:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 16:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-04 16:10:00]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-07-04 23:16:32]

Matt: Minor further tweak to cookie interface, for Mojo compatibility (==
cleanup; Yuzhu suggested that the Mojo interface should be unsigned, and I
decided to drive it down into the cookie implementation rather than put a gasket
at the service layer).  PTAL when you have a chance.

[mmenke, 2017-07-05 16:58:50]

Other than the use of cstdint instead of stdint.h, looks fine.  stdint.h is 110
times more common in chrome/, and in net/, cstdint is only used in quic files
(Though it's in a lot of those).

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.h (right):

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.h:8: #include <cstdint>
cstdint?  stdint.h is what we normally included for these in net/.

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:10: #include <cstdint>
nit:  This is included in the header, so not needed.

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:47: #include <cstdint>
This should be in the header file instead (And should be stdint.h?)

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster_unittest.cc:8: #include <cstdint>
stdint.h?

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:10: #include <cstdint>
stdint.h?

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:8: #include <cstdint>
stdint.h?

[mmenke, 2017-07-05 17:02:55]

Oh, and LGTM - don't think there's any need for a second pass here.

[Randy Smith (Not in Mondays), 2017-07-08 04:47:55]

The CQ bit was checked by rdsmith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 04:48:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 07:05:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-08 07:05:25]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-07-08 13:03:25]

rdsmith@chromium.org changed reviewers:
+ jam@chromium.org, mkwst@chromium.org, rohitrao@chromium.org,
sgurun@chromium.org, sky@chromium.org

[Randy Smith (Not in Mondays), 2017-07-08 13:03:27]

Thanks!  I also shifted cstdint -> stdint.h everywhere else in the patch.

I'm going to TBR everyone else--this is a pretty mechanical change.  TBRs:

android_webview: sgurun@chromium.org
browsing_data: mkwst@chromium.org
chrome/browser/sessions: sky@chromium.org
content: jam@chromium.org 
ios: rohitrao@chromium.org

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.h (right):

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.h:8: #include <cstdint>
On 2017/07/05 16:58:49, mmenke wrote:
> cstdint?  stdint.h is what we normally included for these in net/.

Done.

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2971733002/diff/40001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:10: #include <cstdint>
On 2017/07/05 16:58:49, mmenke wrote:
> nit:  This is included in the header, so not needed.

Done.

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster.cc (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster.cc:47: #include <cstdint>
On 2017/07/05 16:58:49, mmenke wrote:
> This should be in the header file instead (And should be stdint.h?)

Done.

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
File net/cookies/cookie_monster_unittest.cc (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_mons...
net/cookies/cookie_monster_unittest.cc:8: #include <cstdint>
On 2017/07/05 16:58:49, mmenke wrote:
> stdint.h?

Done.

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:10: #include <cstdint>
On 2017/07/05 16:58:49, mmenke wrote:
> stdint.h?

Done.

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
File net/cookies/cookie_store_unittest.h (right):

https://codereview.chromium.org/2971733002/diff/40001/net/cookies/cookie_stor...
net/cookies/cookie_store_unittest.h:8: #include <cstdint>
On 2017/07/05 16:58:50, mmenke wrote:
> stdint.h?

Done.

[Randy Smith (Not in Mondays), 2017-07-08 13:04:35]

Description was changed from

==========
Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG=721395
R=mmenke@chromium.org
==========

to

==========
Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG=721395
R=mmenke@chromium.org
TBR=sgurun@chromium.org
TBR=mkwst@chromium.org
TBR=sky@chromium.org
TBR=jam@chromium.org 
TBR=rohitrao@chromium.org
==========

[Randy Smith (Not in Mondays), 2017-07-08 13:04:57]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2017-07-08 13:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2971733002/#ps60001
(title: "Got rid of rest of <cstdint> stuff.")

[commit-bot: I haz the power, 2017-07-08 13:05:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 13:55:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499519097058480,
"parent_rev": "35a87f9da8aa1268ec4cdf1c0a7e6835ac53b268", "commit_rev":
"a5beda16555c10b32becc695dd03481ea61b9b98"}

[commit-bot: I haz the power, 2017-07-08 13:56:02]

Description was changed from

==========
Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG=721395
R=mmenke@chromium.org
TBR=sgurun@chromium.org
TBR=mkwst@chromium.org
TBR=sky@chromium.org
TBR=jam@chromium.org 
TBR=rohitrao@chromium.org
==========

to

==========
Change CookieStore::DeleteCallback to take uint32_t.

The number of cookies deleted will always be zero or a positive number,
so should be represented by an unsigned.  This is being done to bring
the CookieStore interface into alignment with the Mojo cookie service.

BUG=721395
R=mmenke@chromium.org
TBR=sgurun@chromium.org
TBR=mkwst@chromium.org
TBR=sky@chromium.org
TBR=jam@chromium.org 
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2971733002
Cr-Commit-Position: refs/heads/master@{#485148}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5beda16555c10b32becc695dd03...
==========

[commit-bot: I haz the power, 2017-07-08 13:56:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a5beda16555c10b32becc695dd03...

[sky, 2017-07-11 17:40:00]

chrome/browser/sessions/session_data_deleter.cc LGTM