Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 297173003: Wait for toggle_touch_event_logging to exit so we don't leave zombie processes (Closed)

Created:
6 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 7 months ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Wait for toggle_touch_event_logging to exit so we don't leave zombie processes BUG=376806 TEST=bring up/dismiss the virtual keyboard a few times and then run ps aux to make sure there is no defunct chrome process. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/keyboard/keyboard_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Yufeng Shen (Slow to review)
6 years, 7 months ago (2014-05-26 21:51:03 UTC) #1
kevers
lgtm
6 years, 7 months ago (2014-05-26 22:58:40 UTC) #2
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-26 22:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/297173003/1
6 years, 7 months ago (2014-05-26 22:59:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 02:00:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 02:23:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77741)
6 years, 7 months ago (2014-05-27 02:23:33 UTC) #7
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-27 16:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/297173003/1
6 years, 7 months ago (2014-05-27 16:27:29 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 16:51:30 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 16:58:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77976)
6 years, 7 months ago (2014-05-27 16:58:03 UTC) #12
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-27 21:49:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/297173003/1
6 years, 7 months ago (2014-05-27 21:49:57 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 22:58:10 UTC) #15
Message was sent while issue was closed.
Change committed as 273064

Powered by Google App Engine
This is Rietveld 408576698