ui/keyboard/keyboard_controller.cc - Issue 297173003: Wait for toggle_touch_event_logging to exit so we don't leave zombie processes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 297173003: Wait for toggle_touch_event_logging to exit so we don't leave zombie processes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/keyboard/keyboard_controller.cc

diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc

index 0a2fd1ffce53d00e6fd932503df2e3c11652af86..99bddd817bfce368a13cf4c75ea9ab46bb9d34e6 100644

--- a/ui/keyboard/keyboard_controller.cc

+++ b/ui/keyboard/keyboard_controller.cc

@@ -129,7 +129,9 @@ void ToggleTouchEventLogging(bool enable) {

else

command.AppendArg("0");

VLOG(1) << "Running " << command.GetCommandLineString();

- base::LaunchProcess(command, base::LaunchOptions(), NULL);

+ base::LaunchOptions options;

+ options.wait = true;

+ base::LaunchProcess(command, options, NULL);

#endif

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »