Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2971713002: Use aggregated bindings for jumbo as well as for Windows. (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use aggregated bindings for jumbo as well as for Windows. If the builder requests a jumbo build, use aggregated bindings since that is more or less the same thing. BUG=713137 Review-Url: https://codereview.chromium.org/2971713002 Cr-Commit-Position: refs/heads/master@{#484298} Committed: https://chromium.googlesource.com/chromium/src/+/c5aaecf90aacfdb4c8fce11394431e552f1e6339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Daniel Bratell
bashi, please take a look. This saves roughly 150 CPU minutes of compilation time for ...
3 years, 5 months ago (2017-07-04 14:55:46 UTC) #6
Dirk Pranke
lgtm
3 years, 5 months ago (2017-07-04 17:34:11 UTC) #7
haraken
LGTM
3 years, 5 months ago (2017-07-04 23:58:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971713002/1
3 years, 5 months ago (2017-07-05 15:19:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c5aaecf90aacfdb4c8fce11394431e552f1e6339
3 years, 5 months ago (2017-07-05 17:20:17 UTC) #13
bashi
3 years, 5 months ago (2017-07-06 00:29:59 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698