Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2971683003:
Change code to make jumbo exceptions unnecessary in core/html (Closed)
|
Created:
3 years, 5 months ago by Daniel Bratell Modified:
3 years, 5 months ago Reviewers:
kouhei (in TOK) CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange code to make jumbo exceptions unnecessary in core/html
In jumbo several compilation units are merged so you have to
have more unique names in each one, and don't #undef macros
needed by other compilation units.
BUG=713137
Review-Url: https://codereview.chromium.org/2971683003
Cr-Commit-Position: refs/heads/master@{#485585}
Committed: https://chromium.googlesource.com/chromium/src/+/061195588f7477633e30fc525e394e4af1d13da8
Patch Set 1 #Patch Set 2 : Turn on jumbo for dryrun cq testing #
Total comments: 1
Patch Set 3 : Removed testing code after showing that it worked #
Total comments: 1
Patch Set 4 : Removed the undef instead. #
Messages
Total messages: 28 (20 generated)
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Change code to make jumbo exceptions unnecassary in core/html In jumbo several compilation units are merged so you have to have more unique names in each one, and don't #undef macros needed by other compilation units. BUG=713137 ========== to ========== Change code to make jumbo exceptions unnecessary in core/html In jumbo several compilation units are merged so you have to have more unique names in each one, and don't #undef macros needed by other compilation units. BUG=713137 ==========
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2971683003/diff/20001/build/config/jumbo.gni File build/config/jumbo.gni (right): https://codereview.chromium.org/2971683003/diff/20001/build/config/jumbo.gni#... build/config/jumbo.gni:10: use_jumbo_build = !is_official_build && !(is_android && !is_clang) Must not be committed. Just for CQ testing.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bratell@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/07 13:30:36, Daniel Bratell wrote: > https://codereview.chromium.org/2971683003/diff/20001/build/config/jumbo.gni > File build/config/jumbo.gni (right): > > https://codereview.chromium.org/2971683003/diff/20001/build/config/jumbo.gni#... > build/config/jumbo.gni:10: use_jumbo_build = !is_official_build && !(is_android > && !is_clang) > Must not be committed. Just for CQ testing. Removed
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bratell@opera.com changed reviewers: + kouhei@chromium.org
kouhei, can you please take a look? I'm not sure if the pragma is the best solution. Maybe we should just drop the #undef instead?
lgtm https://codereview.chromium.org/2971683003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp (right): https://codereview.chromium.org/2971683003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp:40: // from multiple threads and DEFINE_STATIC_LOCAL isn't threadsafe. This comment is no longer true. We can just remove the undef + the comment.
The CQ bit was checked by bratell@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2971683003/#ps60001 (title: "Removed the undef instead.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bratell@opera.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499767992125850,
"parent_rev": "c522ea9ee795213721079d29ed2b7fff8e2f2a4e", "commit_rev":
"061195588f7477633e30fc525e394e4af1d13da8"}
Message was sent while issue was closed.
Description was changed from ========== Change code to make jumbo exceptions unnecessary in core/html In jumbo several compilation units are merged so you have to have more unique names in each one, and don't #undef macros needed by other compilation units. BUG=713137 ========== to ========== Change code to make jumbo exceptions unnecessary in core/html In jumbo several compilation units are merged so you have to have more unique names in each one, and don't #undef macros needed by other compilation units. BUG=713137 Review-Url: https://codereview.chromium.org/2971683003 Cr-Commit-Position: refs/heads/master@{#485585} Committed: https://chromium.googlesource.com/chromium/src/+/061195588f7477633e30fc525e39... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/061195588f7477633e30fc525e39... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
