Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2971603002: macOS: Partition alloc should use memory tag 254. (Closed)

Created:
3 years, 5 months ago by erikchen
Modified:
3 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), Mads Ager (chromium), vmpstr+watch_chromium.org, wfh+watch_chromium.org, oilpan-reviews, haraken, danakj+watch_chromium.org, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

macOS: Partition alloc should use memory tag 254. This allows vmmap to more easily distinguish regions allocated by partition alloc. BUG=738926 Review-Url: https://codereview.chromium.org/2971603002 Cr-Commit-Position: refs/heads/master@{#484062} Committed: https://chromium.googlesource.com/chromium/src/+/084a0028a55aeee36ba1886bd78e1048ab7cf3d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M base/allocator/partition_allocator/page_allocator.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
erikchen
haraken: Please review.
3 years, 5 months ago (2017-07-03 17:06:39 UTC) #3
haraken
LGTM Do we want to do this on other platforms?
3 years, 5 months ago (2017-07-03 23:58:58 UTC) #7
erikchen
On 2017/07/03 23:58:58, haraken wrote: > LGTM > > Do we want to do this ...
3 years, 5 months ago (2017-07-04 07:35:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971603002/1
3 years, 5 months ago (2017-07-04 07:35:33 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 07:55:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/084a0028a55aeee36ba1886bd78e...

Powered by Google App Engine
This is Rietveld 408576698