Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2971563002: Use PositionInFlatTreeWithAffinty for SelectionController::original_base_in_flat_tree_ (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PositionInFlatTreeWithAffinty for SelectionController::original_base_in_flat_tree_ This patch changes type of |SelectionController::original_base_in_flat_tree_| to |PositionInFlatTreeWithAffinty| instead of |VisbilePositionInFlatTree| to avoid redundant usage of |VisbilePositionInFlatTree| for improving code health. BUG=657237 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2971563002 Cr-Commit-Position: refs/heads/master@{#483971} Committed: https://chromium.googlesource.com/chromium/src/+/d7a8c49ba1d99cfb63d63cf99840b99317366cdd

Patch Set 1 : 2017-07-03T16:48:36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionController.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-07-03 08:48:00 UTC) #5
yoichio
lgtm
3 years, 5 months ago (2017-07-03 09:21:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2971563002/1
3 years, 5 months ago (2017-07-03 09:30:27 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 09:43:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7a8c49ba1d99cfb63d63cf99840...

Powered by Google App Engine
This is Rietveld 408576698