Set default values for timeout and maximumAge of PositionOptions

Source/bindings/v8/custom/V8GeolocationCustom.cpp

Index: Source/bindings/v8/custom/V8GeolocationCustom.cpp
diff --git a/Source/bindings/v8/custom/V8GeolocationCustom.cpp b/Source/bindings/v8/custom/V8GeolocationCustom.cpp
index 213fab7ee502c910f022a8721af11e1af59734f1..b4f5c596cd8a80df55c3a8c5422a7a73073c2872 100644
--- a/Source/bindings/v8/custom/V8GeolocationCustom.cpp
+++ b/Source/bindings/v8/custom/V8GeolocationCustom.cpp
@@ -105,15 +105,11 @@ static PassRefPtrWillBeRawPtr<PositionOptions> createPositionOptions(v8::Local<v
             return nullptr;
         }
         double maximumAgeDouble = maximumAgeNumber->Value();
-        if (std::isinf(maximumAgeDouble) && maximumAgeDouble > 0) {
-            // If the value is positive infinity, clear maximumAge.
-            options->clearMaximumAge();
+        if ((std::isinf(maximumAgeDouble) && maximumAgeDouble > 0) || maximumAgeDouble <= 0) {
+            // If the value is positive infinity or negative

[Nils Barth (inactive), 2014/05/26 01:20:43]

???
If the value of maximumAge is set to positive infinity,
it should be set to std::numeric_limits<unsigned>::max()
not to 0!

Presumably you're implementing [Clamp]:
// [Clamp] unsigned long maximumAge = 0;
...and for [Clamp], Infinity is mapped to 2^32 - 1, not 0;
compare:
http://www.w3.org/TR/WebIDL/#es-unsigned-long
...with ToUint32 (used when not [Clamp]):
http://es5.github.io/#x9.6

[kihong, 2014/05/26 04:23:43]

You are right.
I will change this with next patch.

+            options->setMaximumAge(0);
         } else {
-            if (maximumAgeDouble <= 0) {
-                options->setMaximumAge(0);
-            } else {
-                options->setMaximumAge(toUInt32(maximumAgeValue, Clamp, exceptionState));
-            }
+            options->setMaximumAge(toUInt32(maximumAgeValue, Clamp, exceptionState));
         }
     }