Set default values for timeout and maximumAge of PositionOptions

Source/bindings/v8/custom/V8GeolocationCustom.cpp

 /*
  * Copyright 2009, The Android Open Source Project
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 87 matching lines @@
         succeeded = false;
         return nullptr;
     }
     if (!maximumAgeValue->IsUndefined()) {
         v8::Local<v8::Number> maximumAgeNumber = maximumAgeValue->ToNumber();
         if (maximumAgeNumber.IsEmpty()) {
             succeeded = false;
             return nullptr;
         }
         double maximumAgeDouble = maximumAgeNumber->Value();
-        if (std::isinf(maximumAgeDouble) && maximumAgeDouble > 0) {
-            // If the value is positive infinity, clear maximumAge.
-            options->clearMaximumAge();
+        if ((std::isinf(maximumAgeDouble) && maximumAgeDouble > 0) || maximumAgeDouble <= 0) {
+            // If the value is positive infinity or negative

[Nils Barth (inactive), 2014/05/26 01:20:43]

???
If the value of maximumAge is set to positive infinity,
it should be set to std::numeric_limits<unsigned>::max()
not to 0!

Presumably you're implementing [Clamp]:
// [Clamp] unsigned long maximumAge = 0;
...and for [Clamp], Infinity is mapped to 2^32 - 1, not 0;
compare:
http://www.w3.org/TR/WebIDL/#es-unsigned-long
...with ToUint32 (used when not [Clamp]):
http://es5.github.io/#x9.6

[kihong, 2014/05/26 04:23:43]

You are right.
I will change this with next patch.

+            options->setMaximumAge(0);
         } else {
-            if (maximumAgeDouble <= 0) {
-                options->setMaximumAge(0);
-            } else {
-                options->setMaximumAge(toUInt32(maximumAgeValue, Clamp, exceptionState));
-            }
+            options->setMaximumAge(toUInt32(maximumAgeValue, Clamp, exceptionState));
         }
     }
 
     return options.release();
 }
 
 void V8Geolocation::getCurrentPositionMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     bool succeeded = false;
 
@@ skipping 38 matching lines @@
     if (!succeeded)
         return;
     ASSERT(positionOptions);
 
     Geolocation* geolocation = V8Geolocation::toNative(info.Holder());
     int watchId = geolocation->watchPosition(positionCallback.release(), positionErrorCallback.release(), positionOptions.release());
     v8SetReturnValue(info, watchId);
 }
 
 } // namespace WebCore