Set default values for timeout and maximumAge of PositionOptions

Set default values for timeout and maximumAge of PositionOptions

Geolocation spec defines default values for both timeout and 
maximumAge but current implementation is working with
hasTimeout and hasMaximumAge functions for emulating that.

Setting initial values of timeout and maximumAge is more proper than using these "has" functions.
In addition, hasZeroTimeout can be removed because it is
enough to check timeout is zero or not and clearMaximumAge
can also be removed, as it is enough to set 0 to maximumAge.

BUG=368184
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175131

[kihong, 2014-05-25 11:05:50]

Review please~:)

[Nils Barth (inactive), 2014-05-26 01:20:42]

Thanks for implementing this!
One comment regarding treatment of +Infinity, otherwise looks ok.

https://codereview.chromium.org/297143003/diff/1/Source/bindings/v8/custom/V8...
File Source/bindings/v8/custom/V8GeolocationCustom.cpp (right):

https://codereview.chromium.org/297143003/diff/1/Source/bindings/v8/custom/V8...
Source/bindings/v8/custom/V8GeolocationCustom.cpp:109: // If the value is
positive infinity or negative
???
If the value of maximumAge is set to positive infinity,
it should be set to std::numeric_limits<unsigned>::max()
not to 0!

Presumably you're implementing [Clamp]:
// [Clamp] unsigned long maximumAge = 0;
...and for [Clamp], Infinity is mapped to 2^32 - 1, not 0;
compare:
http://www.w3.org/TR/WebIDL/#es-unsigned-long
...with ToUint32 (used when not [Clamp]):
http://es5.github.io/#x9.6

[kihong, 2014-05-26 04:23:42]

https://codereview.chromium.org/297143003/diff/1/Source/bindings/v8/custom/V8...
File Source/bindings/v8/custom/V8GeolocationCustom.cpp (right):

https://codereview.chromium.org/297143003/diff/1/Source/bindings/v8/custom/V8...
Source/bindings/v8/custom/V8GeolocationCustom.cpp:109: // If the value is
positive infinity or negative
On 2014/05/26 01:20:43, Nils Barth wrote:
> ???
> If the value of maximumAge is set to positive infinity,
> it should be set to std::numeric_limits<unsigned>::max()
> not to 0!
> 
> Presumably you're implementing [Clamp]:
> // [Clamp] unsigned long maximumAge = 0;
> ...and for [Clamp], Infinity is mapped to 2^32 - 1, not 0;
> compare:

You are right.
I will change this with next patch.
> http://www.w3.org/TR/WebIDL/#es-unsigned-long
> ...with ToUint32 (used when not [Clamp]):
> http://es5.github.io/#x9.6

[haraken, 2014-05-30 00:52:17]

LGTM

[kihong, 2014-05-30 00:56:48]

The CQ bit was checked by kihong.kwon@samsung.com

[commit-bot: I haz the power, 2014-05-30 00:57:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/297143003/20001

[kihong, 2014-05-30 00:58:59]

The CQ bit was unchecked by kihong.kwon@samsung.com

[kihong, 2014-05-30 03:53:32]

The CQ bit was checked by kihong.kwon@samsung.com

[commit-bot: I haz the power, 2014-05-30 03:56:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/297143003/40001

[kihong, 2014-05-30 13:26:00]

The CQ bit was unchecked by kihong.kwon@samsung.com

[kihong, 2014-05-30 13:26:01]

The CQ bit was checked by kihong.kwon@samsung.com

[commit-bot: I haz the power, 2014-05-30 13:27:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/297143003/40001

[commit-bot: I haz the power, 2014-05-30 14:12:38]

Change committed as 175131